Page MenuHomePhabricator
Files F15420492

D14809.id35802.diff
No OneTemporary
Actions

D14809.id35802.diff
View Options

diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -594,6 +594,13 @@
throw new PhabricatorCustomFieldImplementationIncompleteException($this);
}
+ public function didSetValueFromStorage() {
+ if ($this->proxy) {
+ return $this->proxy->didSetValueFromStorage();
+ }
+ return $this;
+ }
+
/* -( ApplicationSearch )-------------------------------------------------- */
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
@@ -73,10 +73,12 @@
$storage = idx($objects, $key);
if ($storage) {
$field->setValueFromStorage($storage->getFieldValue());
+ $field->didSetValueFromStorage();
} else if ($object->getPHID()) {
// NOTE: We set this only if the object exists. Otherwise, we allow the
// field to retain any default value it may have.
$field->setValueFromStorage(null);
+ $field->didSetValueFromStorage();
}
}
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
@@ -16,6 +16,7 @@
private $required;
private $default;
private $isCopyable;
+ private $hasStorageValue;
abstract public function getFieldType();
@@ -215,6 +216,19 @@
return $this->setFieldValue($value);
}
+ public function didSetValueFromStorage() {
+ $this->hasStorageValue = true;
+ return $this;
+ }
+
+ public function getOldValueForApplicationTransactions() {
+ if ($this->hasStorageValue) {
+ return $this->getValueForStorage();
+ } else {
+ return null;
+ }
+ }
+
public function shouldAppearInApplicationTransactions() {
return true;
}

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 22, 2:25 PM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706619
Default Alt Text
D14809.id35802.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility