Page MenuHomePhabricator
Files F15420281

D19594.diff
No OneTemporary
Actions

D19594.diff
View Options

diff --git a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
--- a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
+++ b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
@@ -30,7 +30,8 @@
->addClass('phabricator-core-user-menu')
->setNoCSS(true)
->setDropdown(true)
- ->setDropdownMenu($dropdown);
+ ->setDropdownMenu($dropdown)
+ ->setAuralLabel(pht('Favorites Menu'));
return array(
$favorites_menu,
diff --git a/src/applications/people/engineextension/PeopleMainMenuBarExtension.php b/src/applications/people/engineextension/PeopleMainMenuBarExtension.php
--- a/src/applications/people/engineextension/PeopleMainMenuBarExtension.php
+++ b/src/applications/people/engineextension/PeopleMainMenuBarExtension.php
@@ -43,7 +43,8 @@
->setIcon($profile_image)
->addClass('phabricator-core-user-menu')
->setHasCaret(true)
- ->setNoCSS(true);
+ ->setNoCSS(true)
+ ->setAuralLabel(pht('Account Menu'));
return array(
$user_menu,
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -230,7 +230,7 @@
'div',
array(
'style' => 'background-image: url('.$image_uri.')',
- 'class' => 'phui-comment-image',
+ 'class' => 'phui-comment-image visual-only',
));
$wedge = phutil_tag(
'div',
diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
@@ -233,7 +233,8 @@
->setIcon('fa-reply')
->setTooltip(pht('Reply'))
->addSigil('differential-inline-reply')
- ->setMustCapture(true);
+ ->setMustCapture(true)
+ ->setAuralLabel(pht('Reply'));
}
if ($this->editable && !$this->preview) {
@@ -242,14 +243,16 @@
->setIcon('fa-pencil')
->setTooltip(pht('Edit'))
->addSigil('differential-inline-edit')
- ->setMustCapture(true);
+ ->setMustCapture(true)
+ ->setAuralLabel(pht('Edit'));
$action_buttons[] = id(new PHUIButtonView())
->setTag('a')
->setIcon('fa-trash-o')
->setTooltip(pht('Delete'))
->addSigil('differential-inline-delete')
- ->setMustCapture(true);
+ ->setMustCapture(true)
+ ->setAuralLabel(pht('Delete'));
} else if ($this->preview) {
$links[] = javelin_tag(
@@ -268,7 +271,8 @@
->setTooltip(pht('Delete'))
->setIcon('fa-trash-o')
->addSigil('differential-inline-delete')
- ->setMustCapture(true);
+ ->setMustCapture(true)
+ ->setAuralLabel(pht('Delete'));
}
if (!$this->preview && $this->canHide()) {
@@ -277,7 +281,8 @@
->setTooltip(pht('Collapse'))
->setIcon('fa-times')
->addSigil('hide-inline')
- ->setMustCapture(true);
+ ->setMustCapture(true)
+ ->setAuralLabel(pht('Collapse'));
}
$done_button = null;
diff --git a/src/view/page/menu/PhabricatorMainMenuSearchView.php b/src/view/page/menu/PhabricatorMainMenuSearchView.php
--- a/src/view/page/menu/PhabricatorMainMenuSearchView.php
+++ b/src/view/page/menu/PhabricatorMainMenuSearchView.php
@@ -94,21 +94,24 @@
'action' => '/search/',
'method' => 'POST',
),
- phutil_tag_div('phabricator-main-menu-search-container', array(
- $input,
- phutil_tag(
- 'button',
- array(
- 'id' => $button_id,
- 'class' => 'phui-icon-view phui-font-fa fa-search',
+ phutil_tag(
+ 'div',
+ array(
+ 'class' => 'phabricator-main-menu-search-container',
+ ),
+ array(
+ $input,
+ phutil_tag(
+ 'button',
+ array(
+ 'id' => $button_id,
+ 'class' => 'phui-icon-view phui-font-fa fa-search',
),
- array(
- $selector,
- $search_text,
- )),
- $primary_input,
- $target,
- )));
+ $search_text),
+ $selector,
+ $primary_input,
+ $target,
+ )));
return $form;
}
@@ -207,6 +210,7 @@
id(new PHUIIconView())
->addSigil('global-search-dropdown-icon')
->setIcon($current_icon))
+ ->setAuralLabel(pht('Configure Global Search'))
->setDropdown(true);
$input = javelin_tag(
diff --git a/src/view/page/menu/PhabricatorMainMenuView.php b/src/view/page/menu/PhabricatorMainMenuView.php
--- a/src/view/page/menu/PhabricatorMainMenuView.php
+++ b/src/view/page/menu/PhabricatorMainMenuView.php
@@ -232,7 +232,8 @@
->addClass('phabricator-core-user-menu')
->addClass('phabricator-core-user-mobile-menu')
->setNoCSS(true)
- ->setDropdownMenu($dropdown);
+ ->setDropdownMenu($dropdown)
+ ->setAuralLabel(pht('Page Menu'));
}
private function renderApplicationMenu() {
diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php
--- a/src/view/phui/PHUIButtonView.php
+++ b/src/view/phui/PHUIButtonView.php
@@ -31,6 +31,7 @@
private $noCSS;
private $hasCaret;
private $buttonType = self::BUTTONTYPE_DEFAULT;
+ private $auralLabel;
public function setName($name) {
$this->name = $name;
@@ -123,6 +124,15 @@
return $this->buttonType;
}
+ public function setAuralLabel($aural_label) {
+ $this->auralLabel = $aural_label;
+ return $this;
+ }
+
+ public function getAuralLabel() {
+ return $this->auralLabel;
+ }
+
public function setIcon($icon, $first = true) {
if (!($icon instanceof PHUIIconView)) {
$icon = id(new PHUIIconView())
@@ -265,10 +275,21 @@
$caret = phutil_tag('span', array('class' => 'caret'), '');
}
+ $aural = null;
+ if ($this->auralLabel !== null) {
+ $aural = phutil_tag(
+ 'span',
+ array(
+ 'class' => 'aural-only',
+ ),
+ $this->auralLabel);
+ }
+
+
if ($this->iconFirst == true) {
- return array($icon, $text, $caret);
+ return array($aural, $icon, $text, $caret);
} else {
- return array($text, $icon, $caret);
+ return array($aural, $text, $icon, $caret);
}
}
}
diff --git a/src/view/phui/PHUIHeadThingView.php b/src/view/phui/PHUIHeadThingView.php
--- a/src/view/phui/PHUIHeadThingView.php
+++ b/src/view/phui/PHUIHeadThingView.php
@@ -55,7 +55,7 @@
$image = phutil_tag(
'a',
array(
- 'class' => 'phui-head-thing-image',
+ 'class' => 'phui-head-thing-image visual-only',
'style' => 'background-image: url('.$this->image.');',
'href' => $this->imageHref,
));
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -404,7 +404,7 @@
($this->userHandle->getURI()) ? 'a' : 'div',
array(
'style' => 'background-image: url('.$image_uri.')',
- 'class' => 'phui-timeline-image',
+ 'class' => 'phui-timeline-image visual-only',
'href' => $this->userHandle->getURI(),
),
'');

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 22, 12:45 PM (1 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7717009
Default Alt Text
D19594.diff (7 KB)

Event Timeline

Phabricator · Built by Phacility