D7360.id16607.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D7360.id16607.diff
View Options

	Index: src/applications/differential/editor/DifferentialRevisionEditor.php
	===================================================================
	--- src/applications/differential/editor/DifferentialRevisionEditor.php
	+++ src/applications/differential/editor/DifferentialRevisionEditor.php
	@@ -618,15 +618,6 @@

	$reviewers = $revision->getReviewers();

	- // This is here until the new way proves stable enough
	- // See https://secure.phabricator.com/T1279
	- self::alterReviewers(
	- $revision,
	- $reviewers,
	- $remove_phids,
	- $add_phids,
	- $actor->getPHID());
	-
	$editor = id(new PhabricatorEdgeEditor())
	->setActor($actor);

	@@ -679,18 +670,6 @@
	$reviewer_phid,
	$status) {

	- $reviewers = $revision->getReviewers();
	- if (!in_array($reviewer_phid, $reviewers)) {
	- // This is here until the new way proves stable enough
	- // See https://secure.phabricator.com/T1279
	- self::alterReviewers(
	- $revision,
	- $reviewers,
	- array(),
	- array($reviewer_phid),
	- $actor->getPHID());
	- }
	-
	$options = array(
	'data' => array(
	'status' => $status
	@@ -712,25 +691,6 @@
	->save();
	}

	- /**
	- * @deprecated
	- */
	- private static function alterReviewers(
	- DifferentialRevision $revision,
	- array $stable_phids,
	- array $rem_phids,
	- array $add_phids,
	- $reason_phid) {
	-
	- return self::alterRelationships(
	- $revision,
	- $stable_phids,
	- $rem_phids,
	- $add_phids,
	- $reason_phid,
	- DifferentialRevision::RELATION_REVIEWER);
	- }
	-
	private static function alterRelationships(
	DifferentialRevision $revision,
	array $stable_phids,