Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15417645
D14665.id35471.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D14665.id35471.diff
View Options
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -143,6 +143,9 @@
->setViewer($viewer)
->buildEditEngineCommentView($task);
+ $timeline->setQuoteRef($monogram);
+ $comment_view->setTransactionTimeline($timeline);
+
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
diff --git a/src/applications/paste/controller/PhabricatorPasteViewController.php b/src/applications/paste/controller/PhabricatorPasteViewController.php
--- a/src/applications/paste/controller/PhabricatorPasteViewController.php
+++ b/src/applications/paste/controller/PhabricatorPasteViewController.php
@@ -64,8 +64,9 @@
),
$source_code);
+ $monogram = $paste->getMonogram();
$crumbs = $this->buildApplicationCrumbs()
- ->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
+ ->addTextCrumb($monogram, '/'.$monogram);
$timeline = $this->buildTransactionTimeline(
$paste,
@@ -75,6 +76,9 @@
->setViewer($viewer)
->buildEditEngineCommentView($paste);
+ $timeline->setQuoteRef($monogram);
+ $comment_view->setTransactionTimeline($timeline);
+
return $this->newPage()
->setTitle($paste->getFullName())
->setCrumbs($crumbs)
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -23,6 +23,7 @@
private $currentVersion;
private $versionedDraft;
private $editTypes;
+ private $transactionTimeline;
public function setObjectPHID($object_phid) {
$this->objectPHID = $object_phid;
@@ -110,8 +111,16 @@
return $this->editTypes;
}
- public function render() {
+ public function setTransactionTimeline(
+ PhabricatorApplicationTransactionView $timeline) {
+
+ $timeline->setQuoteTargetID($this->getCommentID());
+
+ $this->transactionTimeline = $timeline;
+ return $this;
+ }
+ public function render() {
$user = $this->getUser();
if (!$user->isLoggedIn()) {
$uri = id(new PhutilURI('/login/'))
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 21, 5:46 PM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7715825
Default Alt Text
D14665.id35471.diff (2 KB)
Attached To
Mode
D14665: Make "Quote" work with EditEngine in Paste and Maniphest
Attached
Detach File
Event Timeline
Log In to Comment