Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15417116
D19290.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D19290.diff
View Options
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -7,7 +7,6 @@
private $isCloseByCommit;
private $repositoryPHIDOverride = false;
private $didExpandInlineState = false;
- private $hasReviewTransaction = false;
private $affectedPaths;
private $firstBroadcast = false;
private $wasBroadcasting;
@@ -128,13 +127,6 @@
// built it for us so we don't need to expand it again.
$this->didExpandInlineState = true;
break;
- case DifferentialRevisionAcceptTransaction::TRANSACTIONTYPE:
- case DifferentialRevisionRejectTransaction::TRANSACTIONTYPE:
- case DifferentialRevisionResignTransaction::TRANSACTIONTYPE:
- // If we have a review transaction, we'll skip marking the user
- // as "Commented" later. This should get cleaner after T10967.
- $this->hasReviewTransaction = true;
- break;
case DifferentialRevisionPlanChangesTransaction::TRANSACTIONTYPE:
if ($xaction->getMetadataValue('draft.demote')) {
$this->isDraftDemotion = true;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 21, 3:27 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7440581
Default Alt Text
D19290.diff (1 KB)
Attached To
Mode
D19290: Clean up an old transaction state flag
Attached
Detach File
Event Timeline
Log In to Comment