Page MenuHomePhabricator

D11238.id27037.diff
No OneTemporary

D11238.id27037.diff

diff --git a/src/workflow/ArcanistCallConduitWorkflow.php b/src/workflow/ArcanistCallConduitWorkflow.php
--- a/src/workflow/ArcanistCallConduitWorkflow.php
+++ b/src/workflow/ArcanistCallConduitWorkflow.php
@@ -40,7 +40,7 @@
);
}
- public function shouldShellComplete() {
+ protected function shouldShellComplete() {
return false;
}
diff --git a/src/workflow/ArcanistGitHookPreReceiveWorkflow.php b/src/workflow/ArcanistGitHookPreReceiveWorkflow.php
--- a/src/workflow/ArcanistGitHookPreReceiveWorkflow.php
+++ b/src/workflow/ArcanistGitHookPreReceiveWorkflow.php
@@ -37,7 +37,7 @@
return true;
}
- public function shouldShellComplete() {
+ protected function shouldShellComplete() {
return false;
}
diff --git a/src/workflow/ArcanistInstallCertificateWorkflow.php b/src/workflow/ArcanistInstallCertificateWorkflow.php
--- a/src/workflow/ArcanistInstallCertificateWorkflow.php
+++ b/src/workflow/ArcanistInstallCertificateWorkflow.php
@@ -35,7 +35,7 @@
);
}
- public function shouldShellComplete() {
+ protected function shouldShellComplete() {
return false;
}
diff --git a/src/workflow/ArcanistPatchWorkflow.php b/src/workflow/ArcanistPatchWorkflow.php
--- a/src/workflow/ArcanistPatchWorkflow.php
+++ b/src/workflow/ArcanistPatchWorkflow.php
@@ -834,7 +834,7 @@
return $commit_message;
}
- public function getShellCompletions(array $argv) {
+ protected function getShellCompletions(array $argv) {
// TODO: Pull open diffs from 'arc list'?
return array('ARGUMENT');
}
diff --git a/src/workflow/ArcanistShellCompleteWorkflow.php b/src/workflow/ArcanistShellCompleteWorkflow.php
--- a/src/workflow/ArcanistShellCompleteWorkflow.php
+++ b/src/workflow/ArcanistShellCompleteWorkflow.php
@@ -36,7 +36,7 @@
);
}
- public function shouldShellComplete() {
+ protected function shouldShellComplete() {
return false;
}
diff --git a/src/workflow/ArcanistSvnHookPreCommitWorkflow.php b/src/workflow/ArcanistSvnHookPreCommitWorkflow.php
--- a/src/workflow/ArcanistSvnHookPreCommitWorkflow.php
+++ b/src/workflow/ArcanistSvnHookPreCommitWorkflow.php
@@ -32,7 +32,7 @@
);
}
- public function shouldShellComplete() {
+ protected function shouldShellComplete() {
return false;
}

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 21, 8:00 AM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7443764
Default Alt Text
D11238.id27037.diff (2 KB)

Event Timeline