Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15414701
D19748.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
902 B
Referenced Files
None
Subscribers
None
D19748.diff
View Options
diff --git a/src/applications/differential/engine/DifferentialChangesetEngine.php b/src/applications/differential/engine/DifferentialChangesetEngine.php
--- a/src/applications/differential/engine/DifferentialChangesetEngine.php
+++ b/src/applications/differential/engine/DifferentialChangesetEngine.php
@@ -88,6 +88,20 @@
private function detectCopiedCode(array $changesets) {
+ // See PHI944. If the total number of changed lines is excessively large,
+ // don't bother with copied code detection. This can take a lot of time and
+ // memory and it's not generally of any use for very large changes.
+ $max_size = 65535;
+
+ $total_size = 0;
+ foreach ($changesets as $changeset) {
+ $total_size += ($changeset->getAddLines() + $changeset->getDelLines());
+ }
+
+ if ($total_size > $max_size) {
+ return;
+ }
+
$min_width = 30;
$min_lines = 3;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 21, 2:00 AM (22 h, 11 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7714777
Default Alt Text
D19748.diff (902 B)
Attached To
Mode
D19748: Skip copied code detection for changes that are too large for it to be useful
Attached
Detach File
Event Timeline
Log In to Comment