Page MenuHomePhabricator
Files F15414525

D11957.id28796.diff
No OneTemporary
Actions

D11957.id28796.diff
View Options

diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -532,7 +532,6 @@
}
$param_table = new AphrontTableView($param_rows);
- $param_table->setDeviceReadyTable(true);
$param_table->setColumnClasses(
array(
'header',
@@ -548,27 +547,20 @@
}
$result_table = new AphrontTableView($result_rows);
- $result_table->setDeviceReadyTable(true);
$result_table->setColumnClasses(
array(
'header',
'wide',
));
- $param_panel = new AphrontPanelView();
- $param_panel->setHeader('Method Parameters');
+ $param_panel = new PHUIObjectBoxView();
+ $param_panel->setHeaderText(pht('Method Parameters'));
$param_panel->appendChild($param_table);
- $result_panel = new AphrontPanelView();
- $result_panel->setHeader('Method Result');
+ $result_panel = new PHUIObjectBoxView();
+ $result_panel->setHeaderText(pht('Method Result'));
$result_panel->appendChild($result_table);
- $param_head = id(new PHUIHeaderView())
- ->setHeader(pht('Method Parameters'));
-
- $result_head = id(new PHUIHeaderView())
- ->setHeader(pht('Method Result'));
-
$method_uri = $this->getApplicationURI('method/'.$method.'/');
$crumbs = $this->buildApplicationCrumbs()
@@ -578,13 +570,11 @@
return $this->buildApplicationPage(
array(
$crumbs,
- $param_head,
- $param_table,
- $result_head,
- $result_table,
+ $param_panel,
+ $result_panel,
),
array(
- 'title' => 'Method Call Result',
+ 'title' => pht('Method Call Result'),
));
}
diff --git a/src/applications/conduit/controller/PhabricatorConduitLogController.php b/src/applications/conduit/controller/PhabricatorConduitLogController.php
--- a/src/applications/conduit/controller/PhabricatorConduitLogController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitLogController.php
@@ -35,6 +35,9 @@
}
$table = $this->renderCallTable($calls, $conns);
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Call Logs'))
+ ->appendChild($table);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Call Logs'));
@@ -42,11 +45,11 @@
return $this->buildApplicationPage(
array(
$crumbs,
- $table,
+ $box,
$pager,
),
array(
- 'title' => 'Conduit Logs',
+ 'title' => pht('Conduit Logs'),
));
}
@@ -100,18 +103,17 @@
);
}
- $table = id(new AphrontTableView($rows))
- ->setDeviceReadyTable(true);
+ $table = id(new AphrontTableView($rows));
$table->setHeaders(
array(
- 'Connection',
- 'User',
- 'Method',
- 'Status',
- 'Error',
- 'Duration',
- 'Date',
+ pht('Connection'),
+ pht('User'),
+ pht('Method'),
+ pht('Status'),
+ pht('Error'),
+ pht('Duration'),
+ pht('Date'),
));
$table->setColumnClasses(
array(

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 21, 1:00 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7714710
Default Alt Text
D11957.id28796.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility