Page MenuHomePhabricator
Files F15414260

D17483.id42042.diff
No OneTemporary
Actions

D17483.id42042.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => '6875302f',
'conpherence.pkg.js' => '6249a1cf',
- 'core.pkg.css' => '7e10ec60',
+ 'core.pkg.css' => 'db710bcc',
'core.pkg.js' => '1fa7c0c5',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '90b30783',
@@ -139,7 +139,7 @@
'rsrc/css/phui/phui-cms.css' => '504b4b23',
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
- 'rsrc/css/phui/phui-crumbs-view.css' => 'ccbf2a0c',
+ 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4',
'rsrc/css/phui/phui-document-pro.css' => 'f56738ed',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
@@ -850,7 +850,7 @@
'phui-cms-css' => '504b4b23',
'phui-comment-form-css' => '48fbd65d',
'phui-comment-panel-css' => 'f50152ad',
- 'phui-crumbs-view-css' => 'ccbf2a0c',
+ 'phui-crumbs-view-css' => '6ece3bbb',
'phui-curtain-view-css' => '947bf1a4',
'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'c32e8dec',
diff --git a/src/view/phui/PHUICrumbView.php b/src/view/phui/PHUICrumbView.php
--- a/src/view/phui/PHUICrumbView.php
+++ b/src/view/phui/PHUICrumbView.php
@@ -75,7 +75,7 @@
// Surround the crumb name with spaces so that double clicking it only
// selects the crumb itself.
- $name = array(' ', $this->name, ' ');
+ $name = array(' ', $this->name);
$name = phutil_tag(
'span',
@@ -84,6 +84,10 @@
),
$name);
+ // Because of text-overflow and safari, put the second space on the
+ // outside of the element.
+ $name = array($name, ' ');
+
$divider = null;
if (!$this->isLastCrumb) {
$divider = id(new PHUIIconView())
diff --git a/webroot/rsrc/css/phui/phui-crumbs-view.css b/webroot/rsrc/css/phui/phui-crumbs-view.css
--- a/webroot/rsrc/css/phui/phui-crumbs-view.css
+++ b/webroot/rsrc/css/phui/phui-crumbs-view.css
@@ -54,13 +54,6 @@
text-overflow: ellipsis;
}
-/* Safari Hack, See D17361 */
-.phui-crumb-view:after {
- content: "\0000a0";
- display: inline-block;
- width: 0;
-}
-
.device-phone .phui-crumb-view.phabricator-last-crumb .phui-crumb-name,
.device-phone .phui-crumb-view.phui-crumb-has-icon,
.device-phone .phui-crumb-has-icon + .phui-crumb-divider {

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 11:45 PM (1 d, 16 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7708882
Default Alt Text
D17483.id42042.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility