Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15414006
D17700.id42568.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D17700.id42568.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -10,7 +10,7 @@
'conpherence.pkg.css' => '437d3b5a',
'conpherence.pkg.js' => '281b1a73',
'core.pkg.css' => 'b2ad82f4',
- 'core.pkg.js' => 'bf3b5cdf',
+ 'core.pkg.js' => 'deabcef7',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '90b30783',
'differential.pkg.js' => 'ddfeb49b',
@@ -510,7 +510,7 @@
'rsrc/js/core/behavior-reorder-applications.js' => '76b9fc3e',
'rsrc/js/core/behavior-reveal-content.js' => '60821bc7',
'rsrc/js/core/behavior-scrollbar.js' => '834a1173',
- 'rsrc/js/core/behavior-search-typeahead.js' => '0f2a0820',
+ 'rsrc/js/core/behavior-search-typeahead.js' => 'eded9ee8',
'rsrc/js/core/behavior-select-content.js' => 'bf5374ef',
'rsrc/js/core/behavior-select-on-click.js' => '4e3e79a6',
'rsrc/js/core/behavior-setup-check-https.js' => '491416b3',
@@ -666,7 +666,7 @@
'javelin-behavior-phabricator-oncopy' => '2926fff2',
'javelin-behavior-phabricator-remarkup-assist' => '0ca788bd',
'javelin-behavior-phabricator-reveal-content' => '60821bc7',
- 'javelin-behavior-phabricator-search-typeahead' => '0f2a0820',
+ 'javelin-behavior-phabricator-search-typeahead' => 'eded9ee8',
'javelin-behavior-phabricator-show-older-transactions' => '94c65b72',
'javelin-behavior-phabricator-tooltips' => 'c420b0b9',
'javelin-behavior-phabricator-transaction-comment-form' => 'b23b49e6',
@@ -988,17 +988,6 @@
'phuix-autocomplete',
'javelin-mask',
),
- '0f2a0820' => array(
- 'javelin-behavior',
- 'javelin-typeahead-ondemand-source',
- 'javelin-typeahead',
- 'javelin-dom',
- 'javelin-uri',
- 'javelin-util',
- 'javelin-stratcom',
- 'phabricator-prefab',
- 'phuix-icon-view',
- ),
'0f764c35' => array(
'javelin-install',
'javelin-util',
@@ -2155,6 +2144,17 @@
'javelin-dom',
'phabricator-draggable-list',
),
+ 'eded9ee8' => array(
+ 'javelin-behavior',
+ 'javelin-typeahead-ondemand-source',
+ 'javelin-typeahead',
+ 'javelin-dom',
+ 'javelin-uri',
+ 'javelin-util',
+ 'javelin-stratcom',
+ 'phabricator-prefab',
+ 'phuix-icon-view',
+ ),
'edf8a145' => array(
'javelin-behavior',
'javelin-uri',
diff --git a/webroot/rsrc/js/core/behavior-search-typeahead.js b/webroot/rsrc/js/core/behavior-search-typeahead.js
--- a/webroot/rsrc/js/core/behavior-search-typeahead.js
+++ b/webroot/rsrc/js/core/behavior-search-typeahead.js
@@ -94,7 +94,6 @@
// If we have more results than fit, limit each type of result to 3, so
// we show 3 applications, then 3 users, etc. For jump items, we show only
// one result.
-
var jj;
var results = [];
for (ii = 0; ii < type_order.length; ii++) {
@@ -108,8 +107,8 @@
// - we have more items than will fit in the typeahead, and this
// is the 4..Nth result of its type.
- var skip = ((current_type == 'jump') && (jj > 1)) ||
- ((list.length > config.limit) && (type_count > 3));
+ var skip = ((current_type == 'jump') && (jj >= 1)) ||
+ ((list.length > config.limit) && (jj >= 3));
if (skip) {
continue;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mar 20 2025, 10:27 PM (4 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7712415
Default Alt Text
D17700.id42568.diff (3 KB)
Attached To
Mode
D17700: Fix a bad variable in global typehaead order/limit code
Attached
Detach File
Event Timeline
Log In to Comment