D11436.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D11436.diff
View Options

	diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
	--- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
	+++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
	@@ -3,6 +3,7 @@
	final class PhabricatorWorkerTriggerQuery
	extends PhabricatorOffsetPagedQuery {

	+ const ORDER_ID = 'id';
	const ORDER_EXECUTION = 'execution';
	const ORDER_VERSION = 'version';

	@@ -14,7 +15,7 @@
	private $nextEpochMax;

	private $needEvents;
	- private $order = self::ORDER_EXECUTION;
	+ private $order = self::ORDER_ID;

	public function withIDs(array $ids) {
	$this->ids = $ids;
	@@ -43,6 +44,16 @@
	return $this;
	}

	+ /**
	+ * Set the result order.
	+ *
	+ * Note that using `ORDER_EXECUTION` will also filter results to include only
	+ * triggers which have been scheduled to execute. You should not use this
	+ * ordering when querying for specific triggers, e.g. by ID or PHID.
	+ *
	+ * @param const Result order.
	+ * @return this
	+ */
	public function setOrder($order) {
	$this->order = $order;
	return $this;
	@@ -185,6 +196,10 @@

	private function buildOrderClause(AphrontDatabaseConnection $conn_r) {
	switch ($this->order) {
	+ case self::ORDER_ID:
	+ return qsprintf(
	+ $conn_r,
	+ 'ORDER BY id DESC');
	case self::ORDER_EXECUTION:
	return qsprintf(
	$conn_r,