Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15413888
D18563.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D18563.diff
View Options
diff --git a/src/applications/herald/controller/HeraldNewController.php b/src/applications/herald/controller/HeraldNewController.php
--- a/src/applications/herald/controller/HeraldNewController.php
+++ b/src/applications/herald/controller/HeraldNewController.php
@@ -194,8 +194,9 @@
->addCancelButton($cancel_uri, $cancel_text));
$form_box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
->setFormErrors($errors)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form);
$crumbs = $this
@@ -203,12 +204,7 @@
->addTextCrumb(pht('Create Rule'))
->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon('fa-plus-square');
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter($form_box);
return $this->newPage()
diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php
--- a/src/applications/herald/controller/HeraldRuleController.php
+++ b/src/applications/herald/controller/HeraldRuleController.php
@@ -241,6 +241,8 @@
$icon = $rule->getID() ? 'fa-pencil' : 'fa-plus-square';
$form_box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setFormErrors($errors)
->setForm($form);
@@ -249,12 +251,7 @@
->addTextCrumb($title)
->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon('fa-plus-square');
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter($form_box);
return $this->newPage()
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 9:49 PM (1 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7666067
Default Alt Text
D18563.diff (1 KB)
Attached To
Mode
D18563: Update herald edit for new UI
Attached
Detach File
Event Timeline
Log In to Comment