Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15413467
D12693.id30516.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D12693.id30516.diff
View Options
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupBoldRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupBoldRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupBoldRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupBoldRule.php
@@ -17,7 +17,7 @@
$text);
}
- protected function applyCallback($matches) {
+ protected function applyCallback(array $matches) {
return hsprintf('<strong>%s</strong>', $matches[1]);
}
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupDelRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupDelRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupDelRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupDelRule.php
@@ -17,7 +17,7 @@
$text);
}
- protected function applyCallback($matches) {
+ protected function applyCallback(array $matches) {
return hsprintf('<del>%s</del>', $matches[1]);
}
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php
@@ -7,7 +7,6 @@
}
public function apply($text) {
-
// Handle mediawiki-style links: [[ href | name ]]
$text = preg_replace_callback(
'@\B\\[\\[([^|\\]]+)(?:\\|([^\\]]+))?\\]\\]\B@U',
@@ -75,7 +74,7 @@
}
}
- public function markupAlternateLink($matches) {
+ public function markupAlternateLink(array $matches) {
$uri = trim($matches[2]);
// NOTE: We apply some special rules to avoid false positives here. The
@@ -104,7 +103,7 @@
));
}
- public function markupDocumentLink($matches) {
+ public function markupDocumentLink(array $matches) {
$uri = trim($matches[1]);
$name = trim(idx($matches, 2, $uri));
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php
@@ -31,7 +31,7 @@
return $text;
}
- protected function markupHyperlink($matches) {
+ protected function markupHyperlink(array $matches) {
$protocols = $this->getEngine()->getConfig(
'uri.allowed-protocols',
array());
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupItalicRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupItalicRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupItalicRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupItalicRule.php
@@ -17,7 +17,7 @@
$text);
}
- protected function applyCallback($matches) {
+ protected function applyCallback(array $matches) {
return hsprintf('<em>%s</em>', $matches[1]);
}
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupMonospaceRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupMonospaceRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupMonospaceRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupMonospaceRule.php
@@ -19,7 +19,7 @@
$text);
}
- protected function markupMonospacedText($matches) {
+ protected function markupMonospacedText(array $matches) {
if ($this->getEngine()->isTextMode()) {
$result = $matches[0];
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupRule.php
@@ -39,7 +39,7 @@
phutil_escape_html($text)));
}
- private function replaceHTMLCallback($match) {
+ private function replaceHTMLCallback(array $match) {
return phutil_escape_html(call_user_func(
$this->replaceCallback,
array_map('phutil_safe_html', $match)));
diff --git a/src/markup/engine/remarkup/markuprule/PhutilRemarkupUnderlineRule.php b/src/markup/engine/remarkup/markuprule/PhutilRemarkupUnderlineRule.php
--- a/src/markup/engine/remarkup/markuprule/PhutilRemarkupUnderlineRule.php
+++ b/src/markup/engine/remarkup/markuprule/PhutilRemarkupUnderlineRule.php
@@ -17,7 +17,7 @@
$text);
}
- protected function applyCallback($matches) {
+ protected function applyCallback(array $matches) {
return hsprintf('<u>%s</u>', $matches[1]);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 6:57 PM (1 w, 6 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7549156
Default Alt Text
D12693.id30516.diff (4 KB)
Attached To
Mode
D12693: Add some missing type hints
Attached
Detach File
Event Timeline
Log In to Comment