Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15413296
D13944.id33656.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13944.id33656.diff
View Options
diff --git a/src/workflow/ArcanistLandWorkflow.php b/src/workflow/ArcanistLandWorkflow.php
--- a/src/workflow/ArcanistLandWorkflow.php
+++ b/src/workflow/ArcanistLandWorkflow.php
@@ -492,17 +492,34 @@
'arc amend',
'--revision <id>'));
} else if (count($revisions) > 1) {
- $message = pht(
- "There are multiple revisions on feature %s '%s' which are not ".
- "present on '%s':\n\n".
- "%s\n".
- "Separate these revisions onto different %s, or use --revision <id>' ".
- "to use the commit message from <id> and land them all.",
- $this->branchType,
- $this->branch,
- $this->onto,
- $this->renderRevisionList($revisions),
- $this->branchType.'s');
+ switch ($this->branchType) {
+ case self::REFTYPE_BOOKMARK:
+ $message = pht(
+ "There are multiple revisions on feature bookmark '%s' which are ".
+ "not present on '%s':\n\n".
+ "%s\n".
+ 'Separate these revisions onto different bookmarks, or use '.
+ '--revision <id> to use the commit message from <id> '.
+ 'and land them all.',
+ $this->branch,
+ $this->onto,
+ $this->renderRevisionList($revisions));
+ break;
+ case self::REFTYPE_BRANCH:
+ default:
+ $message = pht(
+ "There are multiple revisions on feature branch '%s' which are ".
+ "not present on '%s':\n\n".
+ "%s\n".
+ 'Separate these revisions onto different branches, or use '.
+ '--revision <id> to use the commit message from <id> '.
+ 'and land them all.',
+ $this->branch,
+ $this->onto,
+ $this->renderRevisionList($revisions));
+ break;
+ }
+
throw new ArcanistUsageException($message);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 5:53 PM (1 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7528629
Default Alt Text
D13944.id33656.diff (1 KB)
Attached To
Mode
D13944: Fix wrong plural of an `arc land` message
Attached
Detach File
Event Timeline
Log In to Comment