Page MenuHomePhabricator
Files F15413039

D19118.id.diff
No OneTemporary
Actions

D19118.id.diff
View Options

diff --git a/src/applications/auth/view/PhabricatorAuthAccountView.php b/src/applications/auth/view/PhabricatorAuthAccountView.php
--- a/src/applications/auth/view/PhabricatorAuthAccountView.php
+++ b/src/applications/auth/view/PhabricatorAuthAccountView.php
@@ -77,6 +77,7 @@
array(
'href' => $account_uri,
'target' => '_blank',
+ 'rel' => 'noreferrer',
),
$account_uri);
}
diff --git a/src/applications/calendar/import/PhabricatorCalendarICSURIImportEngine.php b/src/applications/calendar/import/PhabricatorCalendarICSURIImportEngine.php
--- a/src/applications/calendar/import/PhabricatorCalendarICSURIImportEngine.php
+++ b/src/applications/calendar/import/PhabricatorCalendarICSURIImportEngine.php
@@ -45,6 +45,7 @@
array(
'href' => $uri,
'target' => '_blank',
+ 'rel' => 'noreferrer',
),
$uri);
}
diff --git a/src/applications/files/markup/PhabricatorImageRemarkupRule.php b/src/applications/files/markup/PhabricatorImageRemarkupRule.php
--- a/src/applications/files/markup/PhabricatorImageRemarkupRule.php
+++ b/src/applications/files/markup/PhabricatorImageRemarkupRule.php
@@ -20,7 +20,6 @@
$defaults = array(
'uri' => null,
'alt' => null,
- 'href' => null,
'width' => null,
'height' => null,
);
@@ -45,10 +44,6 @@
$args += $defaults;
- if ($args['href'] && !PhabricatorEnv::isValidURIForLink($args['href'])) {
- $args['href'] = null;
- }
-
if ($args['uri']) {
$src_uri = id(new PhutilURI('/file/imageproxy/'))
->setQueryParam('uri', (string)$args['uri']);
@@ -57,10 +52,9 @@
array(
'src' => $src_uri,
'alt' => $args['alt'],
- 'href' => $args['href'],
'width' => $args['width'],
'height' => $args['height'],
- ));
+ ));
return $this->getEngine()->storeText($img);
} else {
return $matches[0];
diff --git a/src/applications/harbormaster/artifact/HarbormasterURIArtifact.php b/src/applications/harbormaster/artifact/HarbormasterURIArtifact.php
--- a/src/applications/harbormaster/artifact/HarbormasterURIArtifact.php
+++ b/src/applications/harbormaster/artifact/HarbormasterURIArtifact.php
@@ -81,6 +81,7 @@
array(
'href' => $uri,
'target' => '_blank',
+ 'rel' => 'noreferrer',
),
$name);
}
diff --git a/src/applications/nuance/item/NuanceGitHubEventItemType.php b/src/applications/nuance/item/NuanceGitHubEventItemType.php
--- a/src/applications/nuance/item/NuanceGitHubEventItemType.php
+++ b/src/applications/nuance/item/NuanceGitHubEventItemType.php
@@ -309,6 +309,8 @@
'a',
array(
'href' => $event_uri,
+ 'target' => '_blank',
+ 'rel' => 'noreferrer',
),
$event_uri);
}
diff --git a/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php b/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
--- a/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
+++ b/src/applications/phurl/remarkup/PhabricatorPhurlLinkRemarkupRule.php
@@ -64,6 +64,7 @@
array(
'href' => $uri,
'target' => '_blank',
+ 'rel' => 'noreferrer',
),
$name);
}
diff --git a/src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php
--- a/src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php
@@ -99,7 +99,8 @@
->setHref($href)
->setName($name)
->setIcon($icon_class)
- ->setTooltip($tooltip);
+ ->setTooltip($tooltip)
+ ->setRel('noreferrer');
return array(
$item,
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php
@@ -31,7 +31,11 @@
return phutil_tag(
'a',
- array('href' => $value, 'target' => '_blank'),
+ array(
+ 'href' => $value,
+ 'target' => '_blank',
+ 'rel' => 'noreferrer',
+ ),
$value);
}
diff --git a/src/view/layout/PhabricatorActionView.php b/src/view/layout/PhabricatorActionView.php
--- a/src/view/layout/PhabricatorActionView.php
+++ b/src/view/layout/PhabricatorActionView.php
@@ -255,8 +255,10 @@
} else {
if ($this->getOpenInNewWindow()) {
$target = '_blank';
+ $rel = 'noreferrer';
} else {
$target = null;
+ $rel = null;
}
if ($this->submenu) {
@@ -277,6 +279,7 @@
'href' => $this->getHref(),
'class' => 'phabricator-action-view-item',
'target' => $target,
+ 'rel' => $rel,
'sigil' => $sigils,
'meta' => $this->metadata,
),
diff --git a/src/view/phui/PHUIListItemView.php b/src/view/phui/PHUIListItemView.php
--- a/src/view/phui/PHUIListItemView.php
+++ b/src/view/phui/PHUIListItemView.php
@@ -34,6 +34,7 @@
private $actionIcon;
private $actionIconHref;
private $count;
+ private $rel;
public function setOpenInNewWindow($open_in_new_window) {
$this->openInNewWindow = $open_in_new_window;
@@ -44,7 +45,16 @@
return $this->openInNewWindow;
}
- public function setHideInApplicationMenu($hide) {
+ public function setRel($rel) {
+ $this->rel = $rel;
+ return $this;
+ }
+
+ public function getRel() {
+ return $this->rel;
+ }
+
+ public function setHideInApplicationMenu($hide) {
$this->hideInApplicationMenu = $hide;
return $this;
}
@@ -363,6 +373,7 @@
'meta' => $meta,
'sigil' => $sigil,
'target' => $this->getOpenInNewWindow() ? '_blank' : null,
+ 'rel' => $this->rel,
),
array(
$aural,
diff --git a/src/view/phui/PHUITagView.php b/src/view/phui/PHUITagView.php
--- a/src/view/phui/PHUITagView.php
+++ b/src/view/phui/PHUITagView.php
@@ -154,25 +154,30 @@
$classes[] = 'phui-tag-'.$this->border;
}
+ $attributes = array(
+ 'href' => $this->href,
+ 'class' => $classes,
+ );
+
+ if ($this->external) {
+ $attributes += array(
+ 'target' => '_blank',
+ 'rel' => 'noreferrer',
+ );
+ }
+
if ($this->phid) {
Javelin::initBehavior('phui-hovercards');
- $attributes = array(
- 'href' => $this->href,
+ $attributes += array(
'sigil' => 'hovercard',
- 'meta' => array(
+ 'meta' => array(
'hoverPHID' => $this->phid,
),
- 'target' => $this->external ? '_blank' : null,
- );
- } else {
- $attributes = array(
- 'href' => $this->href,
- 'target' => $this->external ? '_blank' : null,
);
}
- return $attributes + array('class' => $classes);
+ return $attributes;
}
protected function getTagContent() {

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 4:36 PM (2 w, 13 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7394600
Default Alt Text
D19118.id.diff (7 KB)

Event Timeline

Phabricator · Built by Phacility