Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15412952
D9749.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D9749.diff
View Options
diff --git a/src/applications/daemon/storage/PhabricatorDaemonLog.php b/src/applications/daemon/storage/PhabricatorDaemonLog.php
--- a/src/applications/daemon/storage/PhabricatorDaemonLog.php
+++ b/src/applications/daemon/storage/PhabricatorDaemonLog.php
@@ -13,7 +13,7 @@
protected $host;
protected $pid;
protected $argv;
- protected $explicitArgv;
+ protected $explicitArgv = array();
protected $status;
public function getConfiguration() {
@@ -25,6 +25,14 @@
) + parent::getConfiguration();
}
+ public function getExplicitArgv() {
+ $argv = $this->explicitArgv;
+ if (!is_array($argv)) {
+ return array();
+ }
+ return $argv;
+ }
+
/* -( PhabricatorPolicyInterface )----------------------------------------- */
diff --git a/src/infrastructure/daemon/control/PhabricatorDaemonReference.php b/src/infrastructure/daemon/control/PhabricatorDaemonReference.php
--- a/src/infrastructure/daemon/control/PhabricatorDaemonReference.php
+++ b/src/infrastructure/daemon/control/PhabricatorDaemonReference.php
@@ -12,7 +12,13 @@
public static function newFromFile($path) {
$pid_data = Filesystem::readFile($path);
- $dict = phutil_json_decode($pid_data);
+
+ try {
+ $dict = phutil_json_decode($pid_data);
+ } catch (PhutilJSONParserException $ex) {
+ $dict = array();
+ }
+
$ref = self::newFromDictionary($dict);
$ref->pidFile = $path;
return $ref;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 3:57 PM (1 d, 17 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7680688
Default Alt Text
D9749.diff (1 KB)
Attached To
Mode
D9749: Continue on bad daemon pid data
Attached
Detach File
Event Timeline
Log In to Comment