Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15412399
D7343.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D7343.diff
View Options
Index: src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
===================================================================
--- src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
+++ src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
@@ -71,11 +71,6 @@
$form = id(new AphrontFormView())
->setUser($viewer)
- ->appendRemarkupInstructions(
- pht(
- 'NOTE: The "Visible To" control is not yet fully functional. It '.
- 'applies to some interfaces, but some interfaces will bypass this '.
- 'setting and act as though it were set to "all users" for now.'))
->appendChild(
id(new AphrontFormPolicyControl())
->setUser($viewer)
Index: src/applications/maniphest/controller/ManiphestTaskEditController.php
===================================================================
--- src/applications/maniphest/controller/ManiphestTaskEditController.php
+++ src/applications/maniphest/controller/ManiphestTaskEditController.php
@@ -471,10 +471,6 @@
->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
->setPolicyObject($task)
->setPolicies($policies)
- ->setCaption(
- pht(
- 'NOTE: These policy controls still have some rough edges and '.
- 'are not yet fully functional.'))
->setName('editPolicy'))
->appendChild(
id(new AphrontFormTokenizerControl())
Index: src/applications/project/controller/PhabricatorProjectProfileEditController.php
===================================================================
--- src/applications/project/controller/PhabricatorProjectProfileEditController.php
+++ src/applications/project/controller/PhabricatorProjectProfileEditController.php
@@ -131,12 +131,6 @@
->setLabel(pht('Blurb'))
->setName('blurb')
->setValue($profile->getBlurb()))
- ->appendChild(hsprintf(
- '<p class="aphront-form-instructions">%s</p>',
- pht(
- 'NOTE: Policy settings are not yet fully implemented. '.
- 'Some interfaces still ignore these settings, '.
- 'particularly "Visible To".')))
->appendChild(
id(new AphrontFormPolicyControl())
->setUser($user)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 12:51 PM (3 d, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7701650
Default Alt Text
D7343.diff (2 KB)
Attached To
Mode
D7343: Remove UI warnings about policies being a janky mess
Attached
Detach File
Event Timeline
Log In to Comment