Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15411072
D18514.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D18514.diff
View Options
diff --git a/src/applications/search/constants/PhabricatorSearchDocumentFieldType.php b/src/applications/search/constants/PhabricatorSearchDocumentFieldType.php
--- a/src/applications/search/constants/PhabricatorSearchDocumentFieldType.php
+++ b/src/applications/search/constants/PhabricatorSearchDocumentFieldType.php
@@ -6,5 +6,6 @@
const FIELD_BODY = 'body';
const FIELD_COMMENT = 'cmnt';
const FIELD_ALL = 'full';
+ const FIELD_CORE = 'core';
}
diff --git a/src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php b/src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php
--- a/src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php
+++ b/src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php
@@ -32,6 +32,25 @@
$stemmer = new PhutilSearchStemmer();
$ngram_engine = id(new PhabricatorNgramEngine());
+ // Copy all of the "title" and "body" fields to create new "core" fields.
+ // This allows users to search "in title or body" with the "core:" prefix.
+ $document_fields = $document->getFieldData();
+ $virtual_fields = array();
+ foreach ($document_fields as $field) {
+ $virtual_fields[] = $field;
+
+ list($key, $raw_corpus) = $field;
+ switch ($key) {
+ case PhabricatorSearchDocumentFieldType::FIELD_TITLE:
+ case PhabricatorSearchDocumentFieldType::FIELD_BODY:
+ $virtual_fields[] = array(
+ PhabricatorSearchDocumentFieldType::FIELD_CORE,
+ $raw_corpus,
+ );
+ break;
+ }
+ }
+
$key_all = PhabricatorSearchDocumentFieldType::FIELD_ALL;
$empty_template = array(
@@ -44,7 +63,7 @@
$key_all => $empty_template,
);
- foreach ($document->getFieldData() as $field) {
+ foreach ($virtual_fields as $field) {
list($key, $raw_corpus) = $field;
if (!strlen($raw_corpus)) {
continue;
diff --git a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
--- a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
+++ b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
@@ -1406,6 +1406,8 @@
$function_map = array(
'all' => PhabricatorSearchDocumentFieldType::FIELD_ALL,
'title' => PhabricatorSearchDocumentFieldType::FIELD_TITLE,
+ 'body' => PhabricatorSearchDocumentFieldType::FIELD_BODY,
+ 'core' => PhabricatorSearchDocumentFieldType::FIELD_CORE,
);
$current_function = 'all';
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 8:48 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7478063
Default Alt Text
D18514.diff (2 KB)
Attached To
Mode
D18514: Create a virtual "core" field in the Ferret engine for "title and body together"
Attached
Detach File
Event Timeline
Log In to Comment