Page MenuHomePhabricator
Files F15410680

D21165.id50395.diff
No OneTemporary
Actions

D21165.id50395.diff
View Options

diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php
--- a/src/aphront/configuration/AphrontApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontApplicationConfiguration.php
@@ -812,27 +812,22 @@
// if we can. Among other things, this corrects variable names with
// the "." character in them, which PHP normally converts into "_".
- // There are two major considerations here: whether the
- // `enable_post_data_reading` option is set, and whether the content
- // type is "multipart/form-data" or not.
-
- // If `enable_post_data_reading` is off, we're free to read the entire
- // raw request body and parse it -- and we must, because $_POST and
- // $_FILES are not built for us. If `enable_post_data_reading` is on,
- // which is the default, we may not be able to read the body (the
- // documentation says we can't, but empirically we can at least some
- // of the time).
+ // If "enable_post_data_reading" is on, the documentation suggests we
+ // can not read the body. In practice, we seem to be able to. This may
+ // need to be resolved at some point, likely by instructing installs
+ // to disable this option.
// If the content type is "multipart/form-data", we need to build both
// $_POST and $_FILES, which is involved. The body itself is also more
// difficult to parse than other requests.
+
$raw_input = PhabricatorStartup::getRawInput();
$parser = new PhutilQueryStringParser();
if (strlen($raw_input)) {
$content_type = idx($_SERVER, 'CONTENT_TYPE');
$is_multipart = preg_match('@^multipart/form-data@i', $content_type);
- if ($is_multipart && !ini_get('enable_post_data_reading')) {
+ if ($is_multipart) {
$multipart_parser = id(new AphrontMultipartParser())
->setContentType($content_type);

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 8:10 AM (1 d, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7342069
Default Alt Text
D21165.id50395.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility