Page MenuHomePhabricator
Files F15410271

D20900.diff
No OneTemporary
Actions

D20900.diff
View Options

diff --git a/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php b/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php
--- a/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php
+++ b/src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php
@@ -123,8 +123,11 @@
}
public function fillObjectFromData(DoorkeeperExternalObject $obj, $result) {
- $id = $result['id'];
- $uri = "https://app.asana.com/0/{$id}/{$id}";
+ $gid = $result['gid'];
+ $uri = urisprintf(
+ 'https://app.asana.com/0/%s/%s',
+ $gid,
+ $gid);
$obj->setObjectURI($uri);
}
diff --git a/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php b/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php
--- a/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php
+++ b/src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php
@@ -102,7 +102,10 @@
pht('Workspace Name'));
$out[] = '| ------------ | -------------- |';
foreach ($workspaces as $workspace) {
- $out[] = sprintf('| `%s` | `%s` |', $workspace['id'], $workspace['name']);
+ $out[] = sprintf(
+ '| `%s` | `%s` |',
+ $workspace['gid'],
+ $workspace['name']);
}
$out = implode("\n", $out);
diff --git a/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php b/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
--- a/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
+++ b/src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php
@@ -358,7 +358,7 @@
'POST',
$subtask_data + array(
'assignee' => $phid_aid_map[$user_phid],
- 'completed' => $is_completed,
+ 'completed' => (int)$is_completed,
'parent' => $parent_ref->getObjectID(),
));
@@ -393,7 +393,7 @@
'PUT',
$subtask_data + array(
'assignee' => $phid_aid_map[$user_phid],
- 'completed' => $is_completed,
+ 'completed' => (int)$is_completed,
));
}
@@ -484,7 +484,7 @@
return array(
'name' => $title,
'notes' => $notes,
- 'completed' => $is_completed,
+ 'completed' => (int)$is_completed,
);
}
@@ -632,7 +632,7 @@
->setApplicationType(DoorkeeperBridgeAsana::APPTYPE_ASANA)
->setApplicationDomain(DoorkeeperBridgeAsana::APPDOMAIN_ASANA)
->setObjectType($type)
- ->setObjectID($result['id'])
+ ->setObjectID($result['gid'])
->setIsVisible(true);
$xobj = $ref->newExternalObject();

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 6:59 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7384111
Default Alt Text
D20900.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility