Page MenuHomePhabricator

D16579.id39904.diff
No OneTemporary

D16579.id39904.diff

diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php
--- a/src/lint/linter/ArcanistLinter.php
+++ b/src/lint/linter/ArcanistLinter.php
@@ -390,7 +390,14 @@
final protected function addLintMessage(ArcanistLintMessage $message) {
$root = $this->getProjectRoot();
$path = Filesystem::resolvePath($message->getPath(), $root);
- $message->setPath(Filesystem::readablePath($path, $root));
+ $readable_path = Filesystem::readablePath($path, $root);
+ if (phutil_is_windows()) {
+ // Normalize the path back to UNIX-style, so they match the paths
+ // that got passed to the lint engine; otherwise, no path is deemed
+ // "relevant" by isRelevantMessage.
+ $readable_path = str_replace('\\', '/', $readable_path);
+ }
+ $message->setPath($readable_path);
$this->messages[] = $message;
return $message;

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 4:08 AM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7712519
Default Alt Text
D16579.id39904.diff (887 B)

Event Timeline