Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15408739
D20592.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20592.diff
View Options
diff --git a/src/applications/auth/provider/PhabricatorAsanaAuthProvider.php b/src/applications/auth/provider/PhabricatorAsanaAuthProvider.php
--- a/src/applications/auth/provider/PhabricatorAsanaAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorAsanaAuthProvider.php
@@ -59,6 +59,14 @@
return null;
}
+ if (strlen($uri->getFragment())) {
+ return null;
+ }
+
+ if ($uri->getQueryParamsAsPairList()) {
+ return null;
+ }
+
$context_id = $matches[1];
$task_id = $matches[2];
diff --git a/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php b/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php
--- a/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorJIRAAuthProvider.php
@@ -341,6 +341,14 @@
return null;
}
+ if (strlen($uri->getFragment())) {
+ return null;
+ }
+
+ if ($uri->getQueryParamsAsPairList()) {
+ return null;
+ }
+
$domain = $matches[1];
$issue = $matches[2];
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 1:01 AM (5 d, 14 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7475750
Default Alt Text
D20592.diff (1 KB)
Attached To
Mode
D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper)
Attached
Detach File
Event Timeline
Log In to Comment