Page MenuHomePhabricator
Files F15408298

D10819.diff
No OneTemporary
Actions

D10819.diff
View Options

diff --git a/src/applications/phriction/editor/PhrictionTransactionEditor.php b/src/applications/phriction/editor/PhrictionTransactionEditor.php
--- a/src/applications/phriction/editor/PhrictionTransactionEditor.php
+++ b/src/applications/phriction/editor/PhrictionTransactionEditor.php
@@ -587,6 +587,58 @@
}
return $error;
}
+ protected function requireCapabilities(
+ PhabricatorLiskDAO $object,
+ PhabricatorApplicationTransaction $xaction) {
+
+ /*
+ * New objects have a special case. If a user can't see
+ * x/y
+ * then definitely don't let them make some
+ * x/y/z
+ * We need to load the direct parent to handle this case.
+ */
+ if ($this->getIsNewObject()) {
+ $actor = $this->requireActor();
+ $parent_doc = null;
+ $ancestral_slugs = PhabricatorSlug::getAncestry($object->getSlug());
+ // No ancestral slugs is "/"; the first person gets to play with "/".
+ if ($ancestral_slugs) {
+ $parent = end($ancestral_slugs);
+ $parent_doc = id(new PhrictionDocumentQuery())
+ ->setViewer($actor)
+ ->withSlugs(array($parent))
+ ->executeOne();
+ // If the $actor can't see the $parent_doc then they can't create
+ // the child $object; throw a policy exception.
+ if (!$parent_doc) {
+ id(new PhabricatorPolicyFilter())
+ ->setViewer($actor)
+ ->raisePolicyExceptions(true)
+ ->rejectObject(
+ $object,
+ $object->getEditPolicy(),
+ PhabricatorPolicyCapability::CAN_EDIT);
+ }
+
+ // If the $actor can't edit the $parent_doc then they can't create
+ // the child $object; throw a policy exception.
+ if (!PhabricatorPolicyFilter::hasCapability(
+ $actor,
+ $parent_doc,
+ PhabricatorPolicyCapability::CAN_EDIT)) {
+ id(new PhabricatorPolicyFilter())
+ ->setViewer($actor)
+ ->raisePolicyExceptions(true)
+ ->rejectObject(
+ $object,
+ $object->getEditPolicy(),
+ PhabricatorPolicyCapability::CAN_EDIT);
+ }
+ }
+ }
+ return parent::requireCapabilities($object, $xaction);
+ }
protected function supportsSearch() {
return true;

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 10:19 PM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7712102
Default Alt Text
D10819.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility