Page MenuHomePhabricator
Files F15407520

D7329.diff
No OneTemporary
Actions

D7329.diff
View Options

Index: src/applications/differential/controller/DifferentialRevisionViewController.php
===================================================================
--- src/applications/differential/controller/DifferentialRevisionViewController.php
+++ src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -51,6 +51,7 @@
$diff_vs = $request->getInt('vs');
$target_id = $request->getInt('id');
+ phlog($target_id);
$target = idx($diffs, $target_id, end($diffs));
$target_manual = $target;
Index: src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
===================================================================
--- src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
+++ src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
@@ -89,6 +89,8 @@
$new = null;
}
+ phlog($this->selectedVersusDiffID, $this->selectedDiffID);
+
if ($max_id != $id) {
$uniq = celerity_generate_unique_node_id();
$old_checked = ($this->selectedVersusDiffID == $id);
Index: src/infrastructure/celerity/CelerityStaticResourceResponse.php
===================================================================
--- src/infrastructure/celerity/CelerityStaticResourceResponse.php
+++ src/infrastructure/celerity/CelerityStaticResourceResponse.php
@@ -193,6 +193,9 @@
throw new Exception(
'Literal </script> is not allowed inside inline script.');
}
+ if (strpos($data, '<!') !== false) {
+ throw new Exception('Literal <! is not allowed inside inline script.');
+ }
return hsprintf(
// We don't use <![CDATA[ ]]> because it is ignored by HTML parsers. We
// would need to send the document with XHTML content type.

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 6:03 PM (5 d, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7711760
Default Alt Text
D7329.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility