Page MenuHomePhabricator
Files F15407476

D15826.diff
No OneTemporary
Actions

D15826.diff
View Options

diff --git a/src/applications/differential/view/DifferentialReviewersView.php b/src/applications/differential/view/DifferentialReviewersView.php
--- a/src/applications/differential/view/DifferentialReviewersView.php
+++ b/src/applications/differential/view/DifferentialReviewersView.php
@@ -45,82 +45,84 @@
case DifferentialReviewerStatus::STATUS_ADDED:
$item->setIcon(
PHUIStatusItemView::ICON_OPEN,
- 'bluegrey',
- pht('Review Requested'));
+ 'bluegrey');
+ $label = pht('Review Requested');
break;
case DifferentialReviewerStatus::STATUS_ACCEPTED:
if ($is_current) {
$item->setIcon(
PHUIStatusItemView::ICON_ACCEPT,
- 'green',
- pht('Accepted'));
+ 'green');
+ $label = pht('Accepted');
} else {
$item->setIcon(
PHUIStatusItemView::ICON_ACCEPT,
- 'dark',
- pht('Accepted Prior Diff'));
+ 'dark');
+ $label = pht('Accepted Prior Diff');
}
break;
case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER:
$item->setIcon(
PHUIStatusItemView::ICON_ACCEPT,
- 'dark',
- pht('Accepted Prior Diff'));
+ 'dark');
+ $label = pht('Accepted Prior Diff');
break;
case DifferentialReviewerStatus::STATUS_REJECTED:
if ($is_current) {
$item->setIcon(
PHUIStatusItemView::ICON_REJECT,
- 'red',
- pht('Requested Changes'));
+ 'red');
+ $label = pht('Requested Changes');
} else {
$item->setIcon(
PHUIStatusItemView::ICON_REJECT,
- 'dark',
- pht('Requested Changes to Prior Diff'));
+ 'dark');
+ $label = pht('Requested Changes to Prior Diff');
}
break;
case DifferentialReviewerStatus::STATUS_REJECTED_OLDER:
$item->setIcon(
PHUIStatusItemView::ICON_REJECT,
- 'dark',
- pht('Rejected Prior Diff'));
+ 'dark');
+ $label = pht('Rejected Prior Diff');
break;
case DifferentialReviewerStatus::STATUS_COMMENTED:
if ($is_current) {
$item->setIcon(
PHUIStatusItemView::ICON_INFO,
- 'blue',
- pht('Commented'));
+ 'blue');
+ $label = pht('Commented');
} else {
$item->setIcon(
- 'info-dark',
- pht('Commented Previously'));
+ PHUIStatusItemView::ICON_INFO,
+ 'blue');
+ $label = pht('Commented Previously');
}
break;
case DifferentialReviewerStatus::STATUS_BLOCKING:
$item->setIcon(
PHUIStatusItemView::ICON_MINUS,
- 'red',
- pht('Blocking Review'));
+ 'red');
+ $label = pht('Blocking Review');
break;
default:
$item->setIcon(
PHUIStatusItemView::ICON_QUESTION,
- 'bluegrey',
- pht('%s?', $reviewer->getStatus()));
+ 'bluegrey');
+ $label = pht('%s?', $reviewer->getStatus());
break;
}
$item->setTarget($handle->renderHovercardLink());
+ $item->setNote($label);
$view->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 5:42 PM (2 d, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7614016
Default Alt Text
D15826.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility