Page MenuHomePhabricator
Files F15405222

D19204.id45990.diff
No OneTemporary
Actions

D19204.id45990.diff
View Options

diff --git a/src/applications/differential/constants/DifferentialRevisionStatus.php b/src/applications/differential/constants/DifferentialRevisionStatus.php
--- a/src/applications/differential/constants/DifferentialRevisionStatus.php
+++ b/src/applications/differential/constants/DifferentialRevisionStatus.php
@@ -172,10 +172,10 @@
'name' => pht('Draft'),
// For legacy clients, treat this as though it is "Needs Review".
'legacy' => 0,
- 'icon' => 'fa-file-text-o',
+ 'icon' => 'fa-spinner',
'closed' => false,
- 'color.icon' => 'grey',
- 'color.tag' => 'grey',
+ 'color.icon' => 'pink',
+ 'color.tag' => 'pink',
'color.ansi' => null,
),
);
diff --git a/src/applications/differential/customfield/DifferentialDraftField.php b/src/applications/differential/customfield/DifferentialDraftField.php
--- a/src/applications/differential/customfield/DifferentialDraftField.php
+++ b/src/applications/differential/customfield/DifferentialDraftField.php
@@ -37,9 +37,14 @@
}
// If the author has held this revision as a draft explicitly, don't
- // show any misleading messages about it autosubmitting later.
+ // show any misleading messages about it autosubmitting later. We do show
+ // reminder text.
if ($revision->getHoldAsDraft()) {
- return array();
+ return array(
+ pht(
+ 'This is a draft revision that has not yet been submitted for '.
+ 'review.'),
+ );
}
$warnings = array();
@@ -93,4 +98,19 @@
return $warnings;
}
+ public function getWarningsForDetailView() {
+ $revision = $this->getObject();
+
+ if (!$revision->isDraft()) {
+ return array();
+ }
+
+ return array(
+ pht(
+ 'This revision is currently a draft. You can leave comments, but '.
+ 'no one will be notified until the revision is submitted for '.
+ 'review.'),
+ );
+ }
+
}
diff --git a/src/applications/differential/editor/DifferentialRevisionEditEngine.php b/src/applications/differential/editor/DifferentialRevisionEditEngine.php
--- a/src/applications/differential/editor/DifferentialRevisionEditEngine.php
+++ b/src/applications/differential/editor/DifferentialRevisionEditEngine.php
@@ -71,6 +71,14 @@
return pht('Revision');
}
+ protected function getCommentViewButtonText($object) {
+ if ($object->isDraft()) {
+ return pht('Submit Quietly');
+ }
+
+ return parent::getCommentViewButtonText();
+ }
+
protected function getObjectViewURI($object) {
return $object->getURI();
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 10:43 AM (2 w, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7711201
Default Alt Text
D19204.id45990.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility