Page MenuHomePhabricator
Files F15404025

D9709.id23316.diff
No OneTemporary
Actions

D9709.id23316.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => 'daedf92a',
+ 'core.pkg.css' => 'dc953154',
'core.pkg.js' => '8c184823',
'darkconsole.pkg.js' => 'df001cab',
'differential.pkg.css' => '4a93db37',
@@ -142,7 +142,7 @@
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '2f562399',
- 'rsrc/css/phui/phui-tag-view.css' => 'ef0a9ca8',
+ 'rsrc/css/phui/phui-tag-view.css' => '020d419b',
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
'rsrc/css/phui/phui-timeline-view.css' => 'bbd990d0',
'rsrc/css/phui/phui-workboard-view.css' => '2bf82d00',
@@ -491,7 +491,7 @@
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
'rsrc/js/phuix/PHUIXActionView.js' => '6e8cefa4',
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca',
- 'rsrc/swf/aphlict.swf' => 'e5a24c72',
+ 'rsrc/swf/aphlict.swf' => 'f19daffb',
),
'symbols' =>
array(
@@ -787,7 +787,7 @@
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
'phui-status-list-view-css' => '2f562399',
- 'phui-tag-view-css' => 'ef0a9ca8',
+ 'phui-tag-view-css' => '020d419b',
'phui-text-css' => '23e9b4b7',
'phui-timeline-view-css' => 'bbd990d0',
'phui-workboard-view-css' => '2bf82d00',
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -5093,6 +5093,7 @@
2 => 'PhabricatorSubscribableInterface',
3 => 'PhabricatorFlaggableInterface',
4 => 'PhabricatorTokenReceiverInterface',
+ 5 => 'PhabricatorProjectInterface',
),
'PhabricatorSlowvotePollController' => 'PhabricatorSlowvoteController',
'PhabricatorSlowvoteQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
diff --git a/src/applications/phid/PhabricatorObjectHandle.php b/src/applications/phid/PhabricatorObjectHandle.php
--- a/src/applications/phid/PhabricatorObjectHandle.php
+++ b/src/applications/phid/PhabricatorObjectHandle.php
@@ -30,6 +30,10 @@
return $this->getTypeIcon();
}
+ public function getIconColor() {
+ return 'bluegrey';
+ }
+
public function getTypeIcon() {
if ($this->getPHIDType()) {
return $this->getPHIDType()->getTypeIcon();
@@ -255,6 +259,14 @@
array($icon, $name));
}
+ public function renderTag() {
+ return id(new PHUITagView())
+ ->setType(PHUITagView::TYPE_OBJECT)
+ ->setIcon($this->getIcon().' '.$this->getIconColor())
+ ->setHref($this->getURI())
+ ->setName($this->getLinkName());
+ }
+
public function getLinkName() {
switch ($this->getType()) {
case PhabricatorPeoplePHIDTypeUser::TYPECONST:
diff --git a/src/applications/project/events/PhabricatorProjectUIEventListener.php b/src/applications/project/events/PhabricatorProjectUIEventListener.php
--- a/src/applications/project/events/PhabricatorProjectUIEventListener.php
+++ b/src/applications/project/events/PhabricatorProjectUIEventListener.php
@@ -45,9 +45,19 @@
if ($handles) {
$list = array();
foreach ($handles as $handle) {
- $list[] = $handle->renderLink();
+ $list[] = phutil_tag(
+ 'li',
+ array(
+ 'class' => 'phabricator-handle-tag-list-item',
+ ),
+ $handle->renderTag());
}
- $list = phutil_implode_html(phutil_tag('br'), $list);
+ $list = phutil_tag(
+ 'ul',
+ array(
+ 'class' => 'phabricator-handle-tag-list',
+ ),
+ $list);
} else {
$list = phutil_tag('em', array(), pht('None'));
}
diff --git a/webroot/rsrc/css/phui/phui-tag-view.css b/webroot/rsrc/css/phui/phui-tag-view.css
--- a/webroot/rsrc/css/phui/phui-tag-view.css
+++ b/webroot/rsrc/css/phui/phui-tag-view.css
@@ -141,3 +141,7 @@
.phui-tag-core.phui-tag-color-object {
border-color: #d7d7d7;
}
+
+.phabricator-handle-tag-list-item + .phabricator-handle-tag-list-item {
+ margin-top: 4px;
+}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 5:54 AM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7387568
Default Alt Text
D9709.id23316.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility