Files F15403817

D7903.id17897.diff
No OneTemporary
Actions

Size

838 B

Referenced Files

None

Subscribers

None

D7903.id17897.diff
View Options

	Index: src/applications/herald/adapter/HeraldCommitAdapter.php
	===================================================================
	--- src/applications/herald/adapter/HeraldCommitAdapter.php
	+++ src/applications/herald/adapter/HeraldCommitAdapter.php
	@@ -404,8 +404,11 @@
	if (!$revision) {
	return null;
	}
	- $status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
	- if ($revision->getStatus() != $status_accepted) {
	+ // after a revision is accepted, it can be closed (say via arc land)
	+ // so use this function to figure out if it was accepted at one point
	+ // and not later rejected... what a function!
	+ $reviewed_by = $revision->loadReviewedBy();
	+ if (!$reviewed_by) {
	return null;
	}
	return $revision->getPHID();

File Metadata

Mime Type: text/plain
Expires: Wed, Mar 19, 4:58 AM (2 w, 16 h ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 7682692
Default Alt Text: D7903.id17897.diff (838 B)

Event Timeline