Page MenuHomePhabricator
Files F15403647

D17079.id41071.diff
No OneTemporary
Actions

D17079.id41071.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -494,7 +494,6 @@
'DifferentialRevertPlanCommitMessageField' => 'applications/differential/field/DifferentialRevertPlanCommitMessageField.php',
'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php',
'DifferentialReviewedByCommitMessageField' => 'applications/differential/field/DifferentialReviewedByCommitMessageField.php',
- 'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php',
'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php',
'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php',
'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php',
@@ -5142,7 +5141,6 @@
'DifferentialRevertPlanCommitMessageField' => 'DifferentialCommitMessageCustomField',
'DifferentialRevertPlanField' => 'DifferentialStoredCustomField',
'DifferentialReviewedByCommitMessageField' => 'DifferentialCommitMessageField',
- 'DifferentialReviewedByField' => 'DifferentialCoreCustomField',
'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType',
'DifferentialReviewerProxy' => 'Phobject',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -30,7 +30,6 @@
new DifferentialTestPlanField(),
new DifferentialReviewersField(),
new DifferentialProjectReviewersField(),
- new DifferentialReviewedByField(),
new DifferentialSubscribersField(),
new DifferentialRepositoryField(),
new DifferentialViewPolicyField(),
diff --git a/src/applications/differential/customfield/DifferentialReviewedByField.php b/src/applications/differential/customfield/DifferentialReviewedByField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialReviewedByField.php
+++ /dev/null
@@ -1,68 +0,0 @@
-<?php
-
-final class DifferentialReviewedByField
- extends DifferentialCoreCustomField {
-
- public function getFieldKey() {
- return 'differential:reviewed-by';
- }
-
- public function getFieldKeyForConduit() {
- return 'reviewedByPHIDs';
- }
-
- public function getFieldName() {
- return pht('Reviewed By');
- }
-
- public function getFieldDescription() {
- return pht('Records accepting reviewers in the durable message.');
- }
-
- public function shouldAppearInApplicationTransactions() {
- return false;
- }
-
- public function canDisableField() {
- return true;
- }
-
- protected function readValueFromRevision(
- DifferentialRevision $revision) {
-
- $phids = array();
- foreach ($revision->getReviewerStatus() as $reviewer) {
- switch ($reviewer->getStatus()) {
- case DifferentialReviewerStatus::STATUS_ACCEPTED:
- case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER:
- $phids[] = $reviewer->getReviewerPHID();
- break;
- }
- }
-
- return $phids;
- }
-
- public function shouldAppearInCommitMessage() {
- return true;
- }
-
- public function parseValueFromCommitMessage($value) {
- return $this->parseObjectList(
- $value,
- array(
- PhabricatorPeopleUserPHIDType::TYPECONST,
- PhabricatorProjectProjectPHIDType::TYPECONST,
- ),
- $allow_partial = true);
- }
-
- public function getRequiredHandlePHIDsForCommitMessage() {
- return $this->getValue();
- }
-
- public function renderCommitMessageValue(array $handles) {
- return $this->renderObjectList($handles);
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 4:16 AM (3 d, 11 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7710810
Default Alt Text
D17079.id41071.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility