Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15403346
D7779.id17594.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7779.id17594.diff
View Options
Index: src/future/exec/ExecFuture.php
===================================================================
--- src/future/exec/ExecFuture.php
+++ src/future/exec/ExecFuture.php
@@ -22,31 +22,31 @@
*/
final class ExecFuture extends Future {
- protected $pipes = array();
- protected $proc = null;
- protected $start = null;
- protected $timeout = null;
- protected $procStatus = null;
-
- protected $stdout = null;
- protected $stderr = null;
- protected $stdin = null;
- protected $closePipe = true;
-
- protected $stdoutPos = 0;
- protected $stderrPos = 0;
- protected $command = null;
- protected $env = null;
- protected $cwd;
+ private $pipes = array();
+ private $proc = null;
+ private $start = null;
+ private $timeout = null;
+ private $procStatus = null;
+
+ private $stdout = null;
+ private $stderr = null;
+ private $stdin = null;
+ private $closePipe = true;
+
+ private $stdoutPos = 0;
+ private $stderrPos = 0;
+ private $command = null;
+ private $env = null;
+ private $cwd;
private $readBufferSize;
- protected $stdoutSizeLimit = PHP_INT_MAX;
- protected $stderrSizeLimit = PHP_INT_MAX;
+ private $stdoutSizeLimit = PHP_INT_MAX;
+ private $stderrSizeLimit = PHP_INT_MAX;
private $profilerCallID;
private $killedByTimeout;
- protected static $descriptorSpec = array(
+ private static $descriptorSpec = array(
0 => array('pipe', 'r'), // stdin
1 => array('pipe', 'w'), // stdout
2 => array('pipe', 'w'), // stderr
@@ -556,7 +556,7 @@
* @return string The data read from the stream.
* @task internal
*/
- protected function readAndDiscard($stream, $limit, $description, $length) {
+ private function readAndDiscard($stream, $limit, $description, $length) {
$output = '';
if ($length <= 0) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 19, 2:55 AM (6 d, 8 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709243
Default Alt Text
D7779.id17594.diff (1 KB)
Attached To
Mode
D7779: Make all "protected" in ExecFuture into "private"
Attached
Detach File
Event Timeline
Log In to Comment