Page MenuHomePhabricator

D17704.id42579.diff
No OneTemporary

D17704.id42579.diff

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2924,6 +2924,7 @@
'PhabricatorIndexEngine' => 'applications/search/index/PhabricatorIndexEngine.php',
'PhabricatorIndexEngineExtension' => 'applications/search/index/PhabricatorIndexEngineExtension.php',
'PhabricatorIndexEngineExtensionModule' => 'applications/search/index/PhabricatorIndexEngineExtensionModule.php',
+ 'PhabricatorIndexableInterface' => 'applications/search/interface/PhabricatorIndexableInterface.php',
'PhabricatorInfrastructureTestCase' => '__tests__/PhabricatorInfrastructureTestCase.php',
'PhabricatorInlineCommentController' => 'infrastructure/diff/PhabricatorInlineCommentController.php',
'PhabricatorInlineCommentInterface' => 'infrastructure/diff/interface/PhabricatorInlineCommentInterface.php',
@@ -8025,6 +8026,7 @@
'PhabricatorFulltextEngineExtension' => 'Phobject',
'PhabricatorFulltextEngineExtensionModule' => 'PhabricatorConfigModule',
'PhabricatorFulltextIndexEngineExtension' => 'PhabricatorIndexEngineExtension',
+ 'PhabricatorFulltextInterface' => 'PhabricatorIndexableInterface',
'PhabricatorFulltextResultSet' => 'Phobject',
'PhabricatorFulltextStorageEngine' => 'Phobject',
'PhabricatorFulltextToken' => 'Phobject',
@@ -8299,6 +8301,7 @@
'PhabricatorNavigationRemarkupRule' => 'PhutilRemarkupRule',
'PhabricatorNeverTriggerClock' => 'PhabricatorTriggerClock',
'PhabricatorNgramsIndexEngineExtension' => 'PhabricatorIndexEngineExtension',
+ 'PhabricatorNgramsInterface' => 'PhabricatorIndexableInterface',
'PhabricatorNotificationBuilder' => 'Phobject',
'PhabricatorNotificationClearController' => 'PhabricatorNotificationController',
'PhabricatorNotificationClient' => 'Phobject',
diff --git a/src/applications/search/interface/PhabricatorFulltextInterface.php b/src/applications/search/interface/PhabricatorFulltextInterface.php
--- a/src/applications/search/interface/PhabricatorFulltextInterface.php
+++ b/src/applications/search/interface/PhabricatorFulltextInterface.php
@@ -1,6 +1,7 @@
<?php
-interface PhabricatorFulltextInterface {
+interface PhabricatorFulltextInterface
+ extends PhabricatorIndexableInterface {
public function newFulltextEngine();
diff --git a/src/applications/search/interface/PhabricatorIndexableInterface.php b/src/applications/search/interface/PhabricatorIndexableInterface.php
new file mode 100644
--- /dev/null
+++ b/src/applications/search/interface/PhabricatorIndexableInterface.php
@@ -0,0 +1,3 @@
+<?php
+
+interface PhabricatorIndexableInterface {}
diff --git a/src/applications/search/interface/PhabricatorNgramsInterface.php b/src/applications/search/interface/PhabricatorNgramsInterface.php
--- a/src/applications/search/interface/PhabricatorNgramsInterface.php
+++ b/src/applications/search/interface/PhabricatorNgramsInterface.php
@@ -1,6 +1,7 @@
<?php
-interface PhabricatorNgramsInterface {
+interface PhabricatorNgramsInterface
+ extends PhabricatorIndexableInterface {
public function newNgrams();
diff --git a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
--- a/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
@@ -213,7 +213,7 @@
private function loadPHIDsByTypes($type) {
$objects = id(new PhutilClassMapQuery())
- ->setAncestorClass('PhabricatorFulltextInterface')
+ ->setAncestorClass('PhabricatorIndexableInterface')
->execute();
$normalized_type = phutil_utf8_strtolower($type);

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 19, 12:41 AM (6 d, 18 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709570
Default Alt Text
D17704.id42579.diff (3 KB)

Event Timeline