Page MenuHomePhabricator
Files F15401568

D8891.id21099.diff
No OneTemporary
Actions

D8891.id21099.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => '9e7cce62',
+ 'core.pkg.css' => 'b39b2afb',
'core.pkg.js' => '417722ff',
'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '8a064eb7',
@@ -138,7 +138,7 @@
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
'rsrc/css/phui/phui-object-item-list-view.css' => '8b459abe',
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
- 'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
+ 'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '2f562399',
@@ -760,7 +760,7 @@
'phui-object-box-css' => 'ce92d8ec',
'phui-object-item-list-view-css' => '8b459abe',
'phui-pinboard-view-css' => '4b346c2a',
- 'phui-property-list-view-css' => 'dbf53b12',
+ 'phui-property-list-view-css' => 'c4d44192',
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
'phui-status-list-view-css' => '2f562399',
diff --git a/src/applications/herald/controller/HeraldTranscriptController.php b/src/applications/herald/controller/HeraldTranscriptController.php
--- a/src/applications/herald/controller/HeraldTranscriptController.php
+++ b/src/applications/herald/controller/HeraldTranscriptController.php
@@ -511,6 +511,7 @@
}
$property_list = new PHUIPropertyListView();
+ $property_list->setStacked(true);
foreach ($rows as $row) {
$property_list->addProperty($row[0], $row[1]);
}
diff --git a/src/view/phui/PHUIPropertyListView.php b/src/view/phui/PHUIPropertyListView.php
--- a/src/view/phui/PHUIPropertyListView.php
+++ b/src/view/phui/PHUIPropertyListView.php
@@ -8,6 +8,7 @@
private $invokedWillRenderEvent;
private $actionList;
private $classes = array();
+ private $stacked;
const ICON_SUMMARY = 'pl-summary';
const ICON_TESTPLAN = 'pl-testplan';
@@ -26,6 +27,11 @@
return $this;
}
+ public function setStacked($stacked) {
+ $this->stacked = $stacked;
+ return $this;
+ }
+
public function addClass($class) {
$this->classes[] = $class;
return $this;
@@ -158,10 +164,15 @@
array($value, ' '));
}
+ $stacked = '';
+ if ($this->stacked) {
+ $stacked = 'phui-property-list-stacked';
+ }
+
$list = phutil_tag(
'dl',
array(
- 'class' => 'phui-property-list-properties',
+ 'class' => 'phui-property-list-properties '.$stacked,
),
$items);
diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css
--- a/webroot/rsrc/css/phui/phui-property-list-view.css
+++ b/webroot/rsrc/css/phui/phui-property-list-view.css
@@ -55,8 +55,13 @@
margin-bottom: 4px;
}
-.device .phui-property-list-key {
- padding-left: 8px;
+.device .phui-property-list-key,
+.phui-property-list-properties.phui-property-list-stacked
+ .phui-property-list-key {
+ padding-left: 12px;
+ text-align: left;
+ margin-left: 0;
+ width: 100%;
}
.phui-property-list-value {
@@ -71,9 +76,12 @@
margin-bottom: 4px;
}
-.device .phui-property-list-value {
+.device .phui-property-list-value,
+.phui-property-list-properties.phui-property-list-stacked
+ .phui-property-list-value {
padding-left: 16px;
margin-bottom: 8px;
+ width: 100%;
}
.phui-property-list-section-header {

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 18, 6:18 PM (1 d, 3 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7447262
Default Alt Text
D8891.id21099.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility