Page MenuHomePhabricator
Files F15401097

D17340.diff
No OneTemporary
Actions

D17340.diff
View Options

diff --git a/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php b/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
--- a/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
+++ b/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
@@ -13,7 +13,7 @@
public function newQuery() {
return id(new PhabricatorDashboardQuery())
- ->needProjects(true);
+ ->needPanels(true);
}
protected function buildCustomSearchFields() {
@@ -98,25 +98,22 @@
PhabricatorSavedQuery $query,
array $handles) {
- $dashboards = mpull($dashboards, null, 'getPHID');
$viewer = $this->requireViewer();
- $proj_phids = array();
+ $phids = array();
foreach ($dashboards as $dashboard) {
- foreach ($dashboard->getProjectPHIDs() as $project_phid) {
- $proj_phids[] = $project_phid;
+ $author_phid = $dashboard->getAuthorPHID();
+ if ($author_phid) {
+ $phids[] = $author_phid;
}
}
- $proj_handles = id(new PhabricatorHandleQuery())
- ->setViewer($viewer)
- ->withPHIDs($proj_phids)
- ->execute();
+ $handles = $viewer->loadHandles($phids);
$list = id(new PHUIObjectItemListView())
->setUser($viewer);
- foreach ($dashboards as $dashboard_phid => $dashboard) {
+ foreach ($dashboards as $dashboard) {
$id = $dashboard->getID();
$item = id(new PHUIObjectItemView())
@@ -125,27 +122,30 @@
->setHref($this->getApplicationURI("view/{$id}/"))
->setObject($dashboard);
- $project_handles = array_select_keys(
- $proj_handles,
- $dashboard->getProjectPHIDs());
-
- $item->addAttribute(
- id(new PHUIHandleTagListView())
- ->setLimit(4)
- ->setNoDataString(pht('No Projects'))
- ->setSlim(true)
- ->setHandles($project_handles));
-
if ($dashboard->isArchived()) {
$item->setDisabled(true);
}
+ $panels = $dashboard->getPanels();
+ foreach ($panels as $panel) {
+ $item->addAttribute($panel->getName());
+ }
+
+ if (empty($panels)) {
+ $empty = phutil_tag('em', array(), pht('No panels.'));
+ $item->addAttribute($empty);
+ }
+
$icon = id(new PHUIIconView())
->setIcon($dashboard->getIcon())
->setBackground('bg-dark');
$item->setImageIcon($icon);
$item->setEpoch($dashboard->getDateModified());
+ $author_phid = $dashboard->getAuthorPHID();
+ $author_name = $handles[$author_phid]->renderLink();
+ $item->addByline(pht('Author: %s', $author_name));
+
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 18, 3:42 PM (1 d, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7537066
Default Alt Text
D17340.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility