Page MenuHomePhabricator

D7940.diff
No OneTemporary

D7940.diff

Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -416,7 +416,7 @@
'rsrc/js/application/uiexample/notification-example.js' => 'c51a6616',
'rsrc/js/core/Busy.js' => '6453c869',
'rsrc/js/core/DragAndDropFileUpload.js' => 'ae6abfba',
- 'rsrc/js/core/DraggableList.js' => 'f0a4bbdf',
+ 'rsrc/js/core/DraggableList.js' => '6f5a879c',
'rsrc/js/core/DropdownMenu.js' => '2f6f80f4',
'rsrc/js/core/DropdownMenuItem.js' => '0f386ef4',
'rsrc/js/core/FileUpload.js' => '96713558',
@@ -673,7 +673,7 @@
'phabricator-countdown-css' => '86b7b0a0',
'phabricator-crumbs-view-css' => '2d9db584',
'phabricator-drag-and-drop-file-upload' => 'ae6abfba',
- 'phabricator-draggable-list' => 'f0a4bbdf',
+ 'phabricator-draggable-list' => '6f5a879c',
'phabricator-dropdown-menu' => '2f6f80f4',
'phabricator-fatal-config-template-css' => '25d446d6',
'phabricator-feed-css' => '4716c86f',
@@ -1192,6 +1192,15 @@
1 => 'javelin-dom',
2 => 'javelin-workflow',
),
+ '6f5a879c' =>
+ array(
+ 0 => 'javelin-install',
+ 1 => 'javelin-dom',
+ 2 => 'javelin-stratcom',
+ 3 => 'javelin-util',
+ 4 => 'javelin-vector',
+ 5 => 'javelin-magical-init',
+ ),
'71755c79' =>
array(
0 => 'javelin-behavior',
@@ -1847,15 +1856,6 @@
2 => 'javelin-util',
3 => 'javelin-request',
),
- 'f0a4bbdf' =>
- array(
- 0 => 'javelin-install',
- 1 => 'javelin-dom',
- 2 => 'javelin-stratcom',
- 3 => 'javelin-util',
- 4 => 'javelin-vector',
- 5 => 'javelin-magical-init',
- ),
'f2441746' =>
array(
0 => 'javelin-dom',
Index: src/view/phui/PHUIWorkboardView.php
===================================================================
--- src/view/phui/PHUIWorkboardView.php
+++ src/view/phui/PHUIWorkboardView.php
@@ -1,6 +1,6 @@
<?php
-final class PHUIWorkboardView extends AphrontView {
+final class PHUIWorkboardView extends AphrontTagView {
private $panels = array();
private $fluidLayout = false;
@@ -27,7 +27,13 @@
return $this;
}
- public function render() {
+ public function getTagAttributes() {
+ return array(
+ 'class' => 'phui-workboard-view',
+ );
+ }
+
+ public function getTagContent() {
require_celerity_resource('phui-workboard-view-css');
$action_list = null;
@@ -68,14 +74,9 @@
),
$view);
- return phutil_tag(
- 'div',
- array(
- 'class' => 'phui-workboard-view'
- ),
- array(
- $action_list,
- $board
- ));
+ return array(
+ $action_list,
+ $board,
+ );
}
}
Index: src/view/phui/PHUIWorkpanelView.php
===================================================================
--- src/view/phui/PHUIWorkpanelView.php
+++ src/view/phui/PHUIWorkpanelView.php
@@ -1,6 +1,6 @@
<?php
-final class PHUIWorkpanelView extends AphrontView {
+final class PHUIWorkpanelView extends AphrontTagView {
private $cards = array();
private $header;
@@ -33,7 +33,13 @@
return $this;
}
- public function render() {
+ public function getTagAttributes() {
+ return array(
+ 'class' => 'phui-workpanel-view',
+ );
+ }
+
+ public function getTagContent() {
require_celerity_resource('phui-workpanel-view-css');
$footer = '';
@@ -75,11 +81,6 @@
$footer,
));
- return phutil_tag(
- 'div',
- array(
- 'class' => 'phui-workpanel-view'
- ),
- $view);
+ return $view;
}
}

File Metadata

Mime Type
text/plain
Expires
Mar 18 2025, 8:19 AM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7229245
Default Alt Text
D7940.diff (3 KB)

Event Timeline