Page MenuHomePhabricator
Files F15397861

D11206.id26879.diff
No OneTemporary
Actions

D11206.id26879.diff
View Options

diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php
--- a/src/lint/linter/ArcanistExternalLinter.php
+++ b/src/lint/linter/ArcanistExternalLinter.php
@@ -267,34 +267,37 @@
if (!Filesystem::binaryExists($interpreter)) {
throw new ArcanistMissingLinterException(
pht(
- 'Unable to locate interpreter "%s" to run linter %s. You may '.
- 'need to install the interpreter, or adjust your linter '.
- 'configuration.'.
- "\nTO INSTALL: %s",
+ 'Unable to locate interpreter "%s" to run linter %s. You may need '.
+ 'to install the interpreter, or adjust your linter configuration.',
$interpreter,
- get_class($this),
- $this->getInstallInstructions()));
+ get_class($this)));
}
if (!Filesystem::pathExists($binary)) {
throw new ArcanistMissingLinterException(
- pht(
- 'Unable to locate script "%s" to run linter %s. You may need '.
- 'to install the script, or adjust your linter configuration. '.
- "\nTO INSTALL: %s",
- $binary,
- get_class($this),
- $this->getInstallInstructions()));
+ sprintf(
+ "%s\n%s",
+ pht(
+ 'Unable to locate script "%s" to run linter %s. You may need '.
+ 'to install the script, or adjust your linter configuration.',
+ $binary,
+ get_class($this)),
+ pht(
+ 'TO INSTALL: %s',
+ $this->getInstallInstructions())));
}
} else {
if (!Filesystem::binaryExists($binary)) {
throw new ArcanistMissingLinterException(
- pht(
- 'Unable to locate binary "%s" to run linter %s. You may need '.
- 'to install the binary, or adjust your linter configuration. '.
- "\nTO INSTALL: %s",
- $binary,
- get_class($this),
- $this->getInstallInstructions()));
+ sprintf(
+ "%s\n%s",
+ pht(
+ 'Unable to locate binary "%s" to run linter %s. You may need '.
+ 'to install the binary, or adjust your linter configuration.',
+ $binary,
+ get_class($this)),
+ pht(
+ 'TO INSTALL: %s',
+ $this->getInstallInstructions())));
}
}
}
@@ -415,7 +418,11 @@
$future->resolvex();
} else {
throw new Exception(
- "Linter failed to parse output!\n\n{$stdout}\n\n{$stderr}");
+ sprintf(
+ "%s\n\nSTDOUT\n%s\n\nSTDERR\n%s",
+ pht('Linter failed to parse output!'),
+ $stdout,
+ $stderr));
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 10:39 PM (4 d, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7660493
Default Alt Text
D11206.id26879.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility