Page MenuHomePhabricator
Files F15396977

D8330.id19828.diff
No OneTemporary
Actions

D8330.id19828.diff
View Options

Index: resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql
===================================================================
--- /dev/null
+++ resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_differential.differential_revision
+ DROP dateCommitted;
Index: src/applications/differential/conduit/ConduitAPI_differential_close_Method.php
===================================================================
--- src/applications/differential/conduit/ConduitAPI_differential_close_Method.php
+++ src/applications/differential/conduit/ConduitAPI_differential_close_Method.php
@@ -60,7 +60,6 @@
$editor->save();
$revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
- $revision->setDateCommitted(time());
$revision->save();
return;
Index: src/applications/differential/editor/DifferentialCommentEditor.php
===================================================================
--- src/applications/differential/editor/DifferentialCommentEditor.php
+++ src/applications/differential/editor/DifferentialCommentEditor.php
@@ -409,10 +409,6 @@
}
}
- if (!$revision->getDateCommitted()) {
- $revision->setDateCommitted(time());
- }
-
$revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
break;
Index: src/applications/differential/editor/DifferentialTransactionEditor.php
===================================================================
--- src/applications/differential/editor/DifferentialTransactionEditor.php
+++ src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -143,11 +143,6 @@
// TODO: Update review status?
break;
case DifferentialAction::ACTION_CLOSE:
- if (!$object->getDateCommitted()) {
- // TODO: Can we remove this? It is probably no longer used by
- // anything anymore. See also T4434.
- $object->setDateCommitted(time());
- }
$object->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
break;
default:
Index: src/applications/differential/storage/DifferentialRevision.php
===================================================================
--- src/applications/differential/storage/DifferentialRevision.php
+++ src/applications/differential/storage/DifferentialRevision.php
@@ -20,8 +20,6 @@
protected $authorPHID;
protected $lastReviewerPHID;
- protected $dateCommitted;
-
protected $lineCount = 0;
protected $attached = array();
Index: src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
===================================================================
--- src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -117,7 +117,6 @@
$diff = $this->attachToRevision($revision, $actor_phid);
- $revision->setDateCommitted($commit->getEpoch());
$editor = new DifferentialCommentEditor(
$revision,
DifferentialAction::ACTION_CLOSE);

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 5:20 PM (3 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7708303
Default Alt Text
D8330.id19828.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility