Page MenuHomePhabricator
Files F15396635

D20395.id48675.diff
No OneTemporary
Actions

D20395.id48675.diff
View Options

diff --git a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
--- a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
+++ b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
@@ -243,8 +243,6 @@
PhabricatorContentSource $content_source) {
$viewer = $this->getViewer();
- $result_data = array();
-
$new_diff = $this->newDiffFromCommit($commit);
$old_diff = $revision->getActiveDiff();
@@ -261,8 +259,6 @@
$old_diff,
$new_diff);
if ($has_changed) {
- $result_data['vsDiff'] = $old_diff->getID();
-
$revision_monogram = $revision->getMonogram();
$old_id = $old_diff->getID();
$new_id = $new_diff->getID();
@@ -336,8 +332,6 @@
// lost a race to close the revision. That's perfectly fine, we can
// just continue normally.
}
-
- return $result_data;
}
private function loadConcerningBuilds(DifferentialRevision $revision) {
diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -278,17 +278,13 @@
$content_source = $this->newContentSource();
- $update_data = $extraction_engine->updateRevisionWithCommit(
+ $extraction_engine->updateRevisionWithCommit(
$revision,
$commit,
array(
$commit_close_xaction,
),
$content_source);
-
- foreach ($update_data as $key => $value) {
- $data->setCommitDetail($key, $value);
- }
}
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 3:30 PM (5 d, 1 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7549601
Default Alt Text
D20395.id48675.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility