Page MenuHomePhabricator
Files F15395840

D10881.id26132.diff
No OneTemporary
Actions

D10881.id26132.diff
View Options

diff --git a/src/applications/maniphest/controller/ManiphestBatchEditController.php b/src/applications/maniphest/controller/ManiphestBatchEditController.php
--- a/src/applications/maniphest/controller/ManiphestBatchEditController.php
+++ b/src/applications/maniphest/controller/ManiphestBatchEditController.php
@@ -115,11 +115,8 @@
'id' => 'batch-form-actions',
)));
$form->appendChild(
- phutil_tag('p', array(), pht('These tasks will be edited:')));
- $form->appendChild($list);
- $form->appendChild(
id(new PHUIFormInsetView())
- ->setTitle('Actions')
+ ->setTitle(pht('Actions'))
->setRightButton(javelin_tag(
'a',
array(
@@ -146,18 +143,22 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($title);
+ $task_box = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Selected Tasks'))
+ ->appendChild($list);
+
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Batch Edit Tasks'))
+ ->setHeaderText(pht('Batch Editor'))
->setForm($form);
return $this->buildApplicationPage(
array(
$crumbs,
+ $task_box,
$form_box,
),
array(
'title' => $title,
- 'device' => false,
));
}
diff --git a/src/view/form/PHUIFormInsetView.php b/src/view/form/PHUIFormInsetView.php
--- a/src/view/form/PHUIFormInsetView.php
+++ b/src/view/form/PHUIFormInsetView.php
@@ -69,6 +69,7 @@
'style' => 'float: right;',
),
$this->rightButton);
+ $right_button = phutil_tag_div('grouped', $right_button);
}
if ($this->description) {
@@ -76,10 +77,6 @@
'p',
array(),
$this->description);
-
- if ($right_button) {
- $desc = hsprintf('%s<div style="clear: both;"></div>', $desc);
- }
}
$div_attributes = $this->divAttributes;

File Metadata

Mime Type
text/plain
Expires
Mar 17 2025, 10:02 AM (6 w, 10 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7327135
Default Alt Text
D10881.id26132.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility