Page MenuHomePhabricator
Files F15395751

D11278.id.diff
No OneTemporary
Actions

D11278.id.diff
View Options

diff --git a/src/applications/differential/landing/DifferentialLandingStrategy.php b/src/applications/differential/landing/DifferentialLandingStrategy.php
--- a/src/applications/differential/landing/DifferentialLandingStrategy.php
+++ b/src/applications/differential/landing/DifferentialLandingStrategy.php
@@ -10,7 +10,7 @@
/**
* @return PhabricatorActionView or null.
*/
- abstract function createMenuItem(
+ public abstract function createMenuItem(
PhabricatorUser $viewer,
DifferentialRevision $revision,
PhabricatorRepository $repository);
diff --git a/src/applications/drydock/controller/DrydockController.php b/src/applications/drydock/controller/DrydockController.php
--- a/src/applications/drydock/controller/DrydockController.php
+++ b/src/applications/drydock/controller/DrydockController.php
@@ -2,7 +2,7 @@
abstract class DrydockController extends PhabricatorController {
- abstract function buildSideNavView();
+ public abstract function buildSideNavView();
protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
diff --git a/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php b/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php
--- a/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php
+++ b/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php
@@ -2,7 +2,7 @@
final class PhabricatorOwnersPackageTestCase extends PhabricatorTestCase {
- function testFindLongestPathsPerPackage() {
+ public function testFindLongestPathsPerPackage() {
$rows = array(
array('id' => 1, 'excluded' => 0, 'path' => 'src/'),
array('id' => 1, 'excluded' => 1, 'path' => 'src/releeph/'),
diff --git a/src/applications/phragment/controller/PhragmentController.php b/src/applications/phragment/controller/PhragmentController.php
--- a/src/applications/phragment/controller/PhragmentController.php
+++ b/src/applications/phragment/controller/PhragmentController.php
@@ -201,7 +201,7 @@
->addPropertyList($properties);
}
- function renderConfigurationWarningIfRequired() {
+ public function renderConfigurationWarningIfRequired() {
$alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
if ($alt === null) {
return id(new AphrontErrorView())
@@ -225,7 +225,7 @@
* are configured otherwise (because the Files app does not support showing
* the info page to viewers who are not logged in).
*/
- function isCorrectlyConfigured() {
+ public function isCorrectlyConfigured() {
$alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain');
return $alt !== null;
}
diff --git a/src/applications/phragment/controller/PhragmentRevertController.php b/src/applications/phragment/controller/PhragmentRevertController.php
--- a/src/applications/phragment/controller/PhragmentRevertController.php
+++ b/src/applications/phragment/controller/PhragmentRevertController.php
@@ -64,7 +64,7 @@
return $this->createDialog($fragment, $version);
}
- function createDialog(
+ public function createDialog(
PhragmentFragment $fragment,
PhragmentFragmentVersion $version) {
diff --git a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
--- a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
+++ b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php
@@ -36,7 +36,7 @@
return $this->createDialog();
}
- function createDialog() {
+ public function createDialog() {
$request = $this->getRequest();
$viewer = $request->getUser();
diff --git a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
--- a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
+++ b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php
@@ -162,7 +162,7 @@
return $this->createDialog();
}
- function createDialog() {
+ public function createDialog() {
$request = $this->getRequest();
$viewer = $request->getUser();
diff --git a/src/infrastructure/log/PhabricatorAccessLog.php b/src/infrastructure/log/PhabricatorAccessLog.php
--- a/src/infrastructure/log/PhabricatorAccessLog.php
+++ b/src/infrastructure/log/PhabricatorAccessLog.php
@@ -2,7 +2,7 @@
final class PhabricatorAccessLog {
- static $log;
+ private static $log;
public static function init() {
// NOTE: This currently has no effect, but some day we may reuse PHP
diff --git a/src/infrastructure/log/PhabricatorSSHLog.php b/src/infrastructure/log/PhabricatorSSHLog.php
--- a/src/infrastructure/log/PhabricatorSSHLog.php
+++ b/src/infrastructure/log/PhabricatorSSHLog.php
@@ -2,7 +2,7 @@
final class PhabricatorSSHLog extends Phobject {
- static $log;
+ private static $log;
public static function getLog() {
if (!self::$log) {
diff --git a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
--- a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
+++ b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php
@@ -2,8 +2,8 @@
abstract class PhabricatorSQLPatchList {
- abstract function getNamespace();
- abstract function getPatches();
+ public abstract function getNamespace();
+ public abstract function getPatches();
/**
* Examine a directory for `.php` and `.sql` files and build patch

File Metadata

Mime Type
text/plain
Expires
Mar 17 2025, 9:31 AM (6 w, 10 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7442039
Default Alt Text
D11278.id.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility