Page MenuHomePhabricator

D13559.id32760.diff
No OneTemporary

D13559.id32760.diff

diff --git a/src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php b/src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php
--- a/src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php
+++ b/src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php
@@ -10,7 +10,8 @@
);
public function generate() {
- $authorphid = $this->loadPhabrictorUserPHID();
+ $author = $this->loadPhabrictorUser();
+ $authorphid = $author->getPHID();
$language = $this->generateLanguage();
$content = $this->generateContent($language);
$title = $this->generateTitle($language);
@@ -24,12 +25,12 @@
$policy = $this->generatePolicy();
$filephid = $paste_file->getPHID();
$parentphid = $this->loadPhabrictorPastePHID();
- $paste = id(new PhabricatorPaste())
+ $paste = PhabricatorPaste::initializeNewPaste($author)
->setParentPHID($parentphid)
- ->setAuthorPHID($authorphid)
->setTitle($title)
->setLanguage($language)
->setViewPolicy($policy)
+ ->setEditPolicy($policy)
->setFilePHID($filephid)
->save();
return $paste;
diff --git a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
--- a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
+++ b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
@@ -92,7 +92,11 @@
$quantity = min($quantity, count($images));
if ($quantity) {
- foreach (array_rand($images, $quantity) as $random) {
+ $random_images = $quantity === 1 ?
+ array(array_rand($images, $quantity)) :
+ array_rand($images, $quantity);
+
+ foreach ($random_images as $random) {
$rand_images[] = $images[$random]->getPHID();
}
}
diff --git a/src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php b/src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
--- a/src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
+++ b/src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
@@ -9,15 +9,13 @@
$title = $this->generateTitle();
$author = $this->loadPhabrictorUser();
$author_phid = $author->getPHID();
- $project = id(new PhabricatorProject())
- ->setName($title)
- ->setAuthorPHID($author_phid);
+ $project = PhabricatorProject::initializeNewProject($author)
+ ->setName($title);
$this->addTransaction(
PhabricatorProjectTransaction::TYPE_NAME,
$title);
- $this->addTransaction(
- PhabricatorProjectTransaction::TYPE_MEMBERS,
+ $project->attachMemberPHIDs(
$this->loadMembersWithAuthor($author_phid));
$this->addTransaction(
PhabricatorProjectTransaction::TYPE_STATUS,
@@ -35,6 +33,7 @@
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($author)
->setContentSource(PhabricatorContentSource::newConsoleSource())
+ ->setContinueOnNoEffect(true)
->applyTransactions($project, $this->xactions);
return $project->save();

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 8:08 AM (3 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223139
Default Alt Text
D13559.id32760.diff (3 KB)

Event Timeline