Page MenuHomePhabricator
Files F15394825

D9132.id.diff
No OneTemporary
Actions

D9132.id.diff
View Options

diff --git a/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
--- a/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
@@ -73,26 +73,26 @@
}
}
- $buildables = id(new HarbormasterBuildableQuery())
- ->setViewer(PhabricatorUser::getOmnipotentUser())
- ->withBuildablePHIDs($build_objects)
- ->withManualBuildables(false)
- ->execute();
- $buildable_phids = mpull($buildables, 'getPHID');
-
- if (!$buildable_phids) {
- return array();
- }
-
- $builds = id(new HarbormasterBuildQuery())
- ->setViewer(PhabricatorUser::getOmnipotentUser())
- ->withBuildablePHIDs($buildable_phids)
- ->withBuildPlanPHIDs(array($plan->getPHID()))
- ->execute();
-
- foreach ($builds as $build) {
- if (!$build->isComplete()) {
- $blockers[] = pht('Build %d', $build->getID());
+ if ($build_objects) {
+ $buildables = id(new HarbormasterBuildableQuery())
+ ->setViewer(PhabricatorUser::getOmnipotentUser())
+ ->withBuildablePHIDs($build_objects)
+ ->withManualBuildables(false)
+ ->execute();
+ $buildable_phids = mpull($buildables, 'getPHID');
+
+ if ($buildable_phids) {
+ $builds = id(new HarbormasterBuildQuery())
+ ->setViewer(PhabricatorUser::getOmnipotentUser())
+ ->withBuildablePHIDs($buildable_phids)
+ ->withBuildPlanPHIDs(array($plan->getPHID()))
+ ->execute();
+
+ foreach ($builds as $build) {
+ if (!$build->isComplete()) {
+ $blockers[] = pht('Build %d', $build->getID());
+ }
+ }
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 1:16 AM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223215
Default Alt Text
D9132.id.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility