Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15391837
D16182.id38931.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D16182.id38931.diff
View Options
diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php
--- a/src/applications/badges/storage/PhabricatorBadgesBadge.php
+++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php
@@ -186,7 +186,7 @@
->execute();
foreach ($awards as $award) {
- $engine->destroyObjectPermanently($award);
+ $engine->destroyObject($award);
}
$this->openTransaction();
diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php
--- a/src/applications/phame/storage/PhameBlog.php
+++ b/src/applications/phame/storage/PhameBlog.php
@@ -322,10 +322,12 @@
$this->openTransaction();
- $posts = id(new PhamePost())
- ->loadAllWhere('blogPHID = %s', $this->getPHID());
+ $posts = id(new PhamePostQuery())
+ ->setViewer($engine->getViewer())
+ ->withBlogPHIDs(array($this->getPHID()))
+ ->execute();
foreach ($posts as $post) {
- $post->delete();
+ $engine->destroyObject($post);
}
$this->delete();
diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php
--- a/src/applications/phame/storage/PhamePost.php
+++ b/src/applications/phame/storage/PhamePost.php
@@ -258,15 +258,15 @@
return $timeline;
}
+
/* -( PhabricatorDestructibleInterface )----------------------------------- */
+
public function destroyObjectPermanently(
PhabricatorDestructionEngine $engine) {
$this->openTransaction();
-
$this->delete();
-
$this->saveTransaction();
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 16, 11:52 AM (3 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706976
Default Alt Text
D16182.id38931.diff (1 KB)
Attached To
Mode
D16182: Better destruction of PhameBlog, BadgesBadge
Attached
Detach File
Event Timeline
Log In to Comment