Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15391054
D9320.id22116.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D9320.id22116.diff
View Options
diff --git a/src/view/phui/PHUIFeedStoryView.php b/src/view/phui/PHUIFeedStoryView.php
--- a/src/view/phui/PHUIFeedStoryView.php
+++ b/src/view/phui/PHUIFeedStoryView.php
@@ -142,7 +142,6 @@
require_celerity_resource('phui-feed-story-css');
Javelin::initBehavior('phabricator-hovercards');
- $oneline = !$this->hasChildren();
$body = null;
$foot = null;
@@ -186,18 +185,6 @@
$icon->setSpriteSheet(PHUIIconView::SPRITE_APPS);
}
- $ol_foot = null;
- if ($oneline) {
- $ol_foot = phutil_tag(
- 'div',
- array(
- 'class' => 'phui-feed-story-oneline-foot'
- ),
- array(
- $icon,
- $foot));
- }
-
$action_list = array();
$icons = null;
foreach ($this->actions as $action) {
@@ -223,10 +210,9 @@
'class' => 'phui-feed-story-head',
),
array(
- (!$oneline ? $actor : null),
+ $actor,
nonempty($this->title, pht('Untitled Story')),
$icons,
- $ol_foot
));
if (!empty($this->tokenBar)) {
@@ -249,23 +235,16 @@
$body_content);
}
- if ($oneline) {
- $foot = null;
- } else {
- $foot = phutil_tag(
- 'div',
- array(
- 'class' => 'phui-feed-story-foot',
- ),
- array(
- $icon,
- $foot));
- }
+ $foot = phutil_tag(
+ 'div',
+ array(
+ 'class' => 'phui-feed-story-foot',
+ ),
+ array(
+ $icon,
+ $foot));
$classes = array('phui-feed-story');
- if ($oneline) {
- $classes[] = 'phui-feed-story-oneline';
- }
return id(new PHUIBoxView())
->addClass(implode(' ', $classes))
@@ -282,6 +261,15 @@
case PhabricatorMacroPHIDTypeMacro::TYPECONST:
$this->setAppIcon("macro-dark");
break;
+ case ManiphestPHIDTypeTask::TYPECONST:
+ $this->setAppIcon('maniphest-dark');
+ break;
+ case DifferentialPHIDTypeRevision::TYPECONST:
+ $this->setAppIcon('differential-dark');
+ break;
+ case PhabricatorCalendarPHIDTypeEvent::TYPECONST:
+ $this->setAppIcon('calendar-dark');
+ break;
}
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 16, 8:00 AM (5 d, 18 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7381505
Default Alt Text
D9320.id22116.diff (2 KB)
Attached To
Mode
D9320: Remove oneline feed story
Attached
Detach File
Event Timeline
Log In to Comment