Page MenuHomePhabricator

D17285.id.diff
No OneTemporary

D17285.id.diff

diff --git a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
--- a/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
+++ b/src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
@@ -61,14 +61,10 @@
$view = id(new PhabricatorActionListView())
->setViewer($viewer);
foreach ($item_views as $item) {
- $type = null;
- if (!strlen($item->getName())) {
- $type = PhabricatorActionView::TYPE_DIVIDER;
- }
$action = id(new PhabricatorActionView())
->setName($item->getName())
->setHref($item->getHref())
- ->setType($type);
+ ->setType($item->getType());
$view->addAction($action);
}
diff --git a/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
--- a/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
@@ -38,6 +38,7 @@
PhabricatorProfileMenuItemConfiguration $config) {
$item = $this->newItem()
+ ->setType(PHUIListItemView::TYPE_DIVIDER)
->addClass('phui-divider');
return array(

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 4:54 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7695882
Default Alt Text
D17285.id.diff (1 KB)

Event Timeline