Page MenuHomePhabricator
Files F15388120

D17362.diff
No OneTemporary
Actions

D17362.diff
View Options

diff --git a/src/workflow/ArcanistSetConfigWorkflow.php b/src/workflow/ArcanistSetConfigWorkflow.php
--- a/src/workflow/ArcanistSetConfigWorkflow.php
+++ b/src/workflow/ArcanistSetConfigWorkflow.php
@@ -72,11 +72,14 @@
$console = PhutilConsole::getConsole();
if (!$settings->getHelp($key)) {
- $warn = pht(
- 'The configuration key \'%s\' is not recognized by arc. It may '.
- 'be misspelled or out of date.',
- $key);
- $console->writeErr("**%s:** %s\n", pht('Warning'), $warn);
+ $warning = tsprintf(
+ "**%s:** %s\n",
+ pht('Warning'),
+ pht(
+ 'The configuration key "%s" is not recognized by arc. It may '.
+ 'be misspelled or out of date.',
+ $key));
+ $console->writeErr('%s', $warning);
}
$old = null;
@@ -95,17 +98,18 @@
$old = $settings->formatConfigValueForDisplay($key, $old);
if ($old === null) {
- $console->writeOut(
- "Deleted key '%s' from %s config.\n",
+ $message = pht(
+ 'Deleted key "%s" from %s config.',
$key,
$which);
} else {
- $console->writeOut(
- "Deleted key '%s' from %s config (was %s).\n",
+ $message = pht(
+ 'Deleted key "%s" from %s config (was %s).',
$key,
$which,
$old);
}
+ $console->writeOut('%s', tsprintf("%s\n", $message));
} else {
$val = $settings->willWriteValue($key, $val);
@@ -120,19 +124,20 @@
$old = $settings->formatConfigValueForDisplay($key, $old);
if ($old === null) {
- $console->writeOut(
- "Set key '%s' = %s in %s config.\n",
+ $message = pht(
+ 'Set key "%s" = %s in %s config.',
$key,
$val,
$which);
} else {
- $console->writeOut(
- "Set key '%s' = %s in %s config (was %s).\n",
+ $message = pht(
+ 'Set key "%s" = %s in %s config (was %s).',
$key,
$val,
$which,
$old);
}
+ $console->writeOut('%s', tsprintf("%s\n", $message));
}
return 0;

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 3:20 AM (6 d, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7705459
Default Alt Text
D17362.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility