Page MenuHomePhabricator
Files F15387128

D9750.id23413.diff
No OneTemporary
Actions

D9750.id23413.diff
View Options

diff --git a/src/applications/config/controller/PhabricatorConfigAllController.php b/src/applications/config/controller/PhabricatorConfigAllController.php
--- a/src/applications/config/controller/PhabricatorConfigAllController.php
+++ b/src/applications/config/controller/PhabricatorConfigAllController.php
@@ -39,7 +39,6 @@
);
}
$table = id(new AphrontTableView($rows))
- ->setDeviceReadyTable(true)
->setColumnClasses(
array(
'',
@@ -58,9 +57,9 @@
->buildApplicationCrumbs()
->addTextCrumb($title);
- $panel = new AphrontPanelView();
+ $panel = new PHUIObjectBoxView();
+ $panel->setHeaderText(pht('Current Settings'));
$panel->appendChild($table);
- $panel->setNoBackground();
$versions = $this->loadVersions();
@@ -71,7 +70,7 @@
}
$object_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Current Settings'))
+ ->setHeaderText(pht('Current Version'))
->addPropertyList($version_property_list);
$phabricator_root = dirname(phutil_get_library_root('phabricator'));
diff --git a/src/applications/config/controller/PhabricatorConfigGroupController.php b/src/applications/config/controller/PhabricatorConfigGroupController.php
--- a/src/applications/config/controller/PhabricatorConfigGroupController.php
+++ b/src/applications/config/controller/PhabricatorConfigGroupController.php
@@ -20,12 +20,12 @@
}
$title = pht('%s Configuration', $options->getName());
-
- $header = id(new PHUIHeaderView())
- ->setHeader($title);
-
$list = $this->buildOptionList($options->getOptions());
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
+ ->appendChild($list);
+
$crumbs = $this
->buildApplicationCrumbs()
->addTextCrumb(pht('Config'), $this->getApplicationURI())
@@ -34,8 +34,7 @@
return $this->buildApplicationPage(
array(
$crumbs,
- $header,
- $list,
+ $box,
),
array(
'title' => $title,
diff --git a/src/applications/config/controller/PhabricatorConfigIssueListController.php b/src/applications/config/controller/PhabricatorConfigIssueListController.php
--- a/src/applications/config/controller/PhabricatorConfigIssueListController.php
+++ b/src/applications/config/controller/PhabricatorConfigIssueListController.php
@@ -16,14 +16,15 @@
$list = $this->buildIssueList($issues);
$list->setNoDataString(pht('There are no open setup issues.'));
+ $list->setStackable(true);
- $header = id(new PHUIHeaderView())
- ->setHeader(pht('Open Phabricator Setup Issues'));
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Open Phabricator Setup Issues'))
+ ->appendChild($list);
$nav->appendChild(
array(
- $header,
- $list,
+ $box,
));
$title = pht('Setup Issues');
diff --git a/src/applications/config/controller/PhabricatorConfigListController.php b/src/applications/config/controller/PhabricatorConfigListController.php
--- a/src/applications/config/controller/PhabricatorConfigListController.php
+++ b/src/applications/config/controller/PhabricatorConfigListController.php
@@ -15,7 +15,14 @@
$title = pht('Phabricator Configuration');
- $nav->appendChild($list);
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
+ ->appendChild($list);
+
+ $nav->appendChild(
+ array(
+ $box
+ ));
$crumbs = $this
->buildApplicationCrumbs()
diff --git a/webroot/rsrc/css/phui/phui-document.css b/webroot/rsrc/css/phui/phui-document.css
--- a/webroot/rsrc/css/phui/phui-document.css
+++ b/webroot/rsrc/css/phui/phui-document.css
@@ -88,6 +88,7 @@
.phui-document-content .phui-header-view {
color: {$bluetext};
text-shadow: 0 1px 2px #fff;
+ padding: 16px;
}
.phui-document-content .phui-property-list-container {
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -6,7 +6,7 @@
background-color: #e0e3ec;
border-width: 1px 0;
border-style: solid;
- border-color: #c0c5d1;
+ border-color: {$hovergrey};
overflow: hidden;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 1:53 AM (6 d, 13 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7705028
Default Alt Text
D9750.id23413.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility