Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15386809
D20224.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20224.diff
View Options
diff --git a/src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php b/src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php
--- a/src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php
+++ b/src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php
@@ -124,29 +124,6 @@
return $where;
}
- protected function didFilterPage(array $identities) {
- $user_ids = array_filter(
- mpull($identities, 'getCurrentEffectiveUserPHID', 'getID'));
- if (!$user_ids) {
- return $identities;
- }
-
- $users = id(new PhabricatorPeopleQuery())
- ->withPHIDs($user_ids)
- ->setViewer($this->getViewer())
- ->execute();
- $users = mpull($users, null, 'getPHID');
-
- foreach ($identities as $identity) {
- if ($identity->hasEffectiveUser()) {
- $user = idx($users, $identity->getCurrentEffectiveUserPHID());
- $identity->attachEffectiveUser($user);
- }
- }
-
- return $identities;
- }
-
public function getQueryApplicationClass() {
return 'PhabricatorDiffusionApplication';
}
diff --git a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php
--- a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php
@@ -14,17 +14,6 @@
protected $manuallySetUserPHID;
protected $currentEffectiveUserPHID;
- private $effectiveUser = self::ATTACHABLE;
-
- public function attachEffectiveUser(PhabricatorUser $user) {
- $this->effectiveUser = $user;
- return $this;
- }
-
- public function getEffectiveUser() {
- return $this->assertAttached($this->effectiveUser);
- }
-
protected function getConfiguration() {
return array(
self::CONFIG_AUX_PHID => true,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 16, 1:19 AM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7383269
Default Alt Text
D20224.diff (1 KB)
Attached To
Mode
D20224: Remove "Effective User" attachment from Repository Identities
Attached
Detach File
Event Timeline
Log In to Comment