Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15385020
D14864.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D14864.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -152,7 +152,7 @@
'rsrc/css/phui/phui-text.css' => 'cf019f54',
'rsrc/css/phui/phui-timeline-view.css' => '2efceff8',
'rsrc/css/phui/phui-two-column-view.css' => '39ecafb1',
- 'rsrc/css/phui/phui-workboard-view.css' => '6704d68d',
+ 'rsrc/css/phui/phui-workboard-view.css' => '24fe2a66',
'rsrc/css/phui/phui-workpanel-view.css' => 'adec7699',
'rsrc/css/sprite-login.css' => '60e8560e',
'rsrc/css/sprite-main-header.css' => 'f07bbb87',
@@ -828,7 +828,7 @@
'phui-theme-css' => '6b451f24',
'phui-timeline-view-css' => '2efceff8',
'phui-two-column-view-css' => '39ecafb1',
- 'phui-workboard-view-css' => '6704d68d',
+ 'phui-workboard-view-css' => '24fe2a66',
'phui-workpanel-view-css' => 'adec7699',
'phuix-action-list-view' => 'b5c256b8',
'phuix-action-view' => '8cf6d262',
diff --git a/src/view/phui/PHUIWorkboardView.php b/src/view/phui/PHUIWorkboardView.php
--- a/src/view/phui/PHUIWorkboardView.php
+++ b/src/view/phui/PHUIWorkboardView.php
@@ -3,8 +3,6 @@
final class PHUIWorkboardView extends AphrontTagView {
private $panels = array();
- private $fluidLayout = false;
- private $fluidishLayout = false;
private $actions = array();
public function addPanel(PHUIWorkpanelView $panel) {
@@ -12,21 +10,6 @@
return $this;
}
- public function setFluidLayout($layout) {
- $this->fluidLayout = $layout;
- return $this;
- }
-
- public function setFluidishLayout($layout) {
- $this->fluidishLayout = $layout;
- return $this;
- }
-
- public function addAction(PHUIIconView $action) {
- $this->actions[] = $action;
- return $this;
- }
-
protected function getTagAttributes() {
return array(
'class' => 'phui-workboard-view',
@@ -36,33 +19,8 @@
protected function getTagContent() {
require_celerity_resource('phui-workboard-view-css');
- $action_list = null;
- if (!empty($this->actions)) {
- $items = array();
- foreach ($this->actions as $action) {
- $items[] = phutil_tag(
- 'li',
- array(
- 'class' => 'phui-workboard-action-item',
- ),
- $action);
- }
- $action_list = phutil_tag(
- 'ul',
- array(
- 'class' => 'phui-workboard-action-list',
- ),
- $items);
- }
-
$view = new AphrontMultiColumnView();
$view->setGutter(AphrontMultiColumnView::GUTTER_MEDIUM);
- if ($this->fluidLayout) {
- $view->setFluidLayout($this->fluidLayout);
- }
- if ($this->fluidishLayout) {
- $view->setFluidishLayout($this->fluidishLayout);
- }
foreach ($this->panels as $panel) {
$view->addColumn($panel);
}
@@ -74,9 +32,6 @@
),
$view);
- return array(
- $action_list,
- $board,
- );
+ return $board;
}
}
diff --git a/webroot/rsrc/css/phui/phui-workboard-view.css b/webroot/rsrc/css/phui/phui-workboard-view.css
--- a/webroot/rsrc/css/phui/phui-workboard-view.css
+++ b/webroot/rsrc/css/phui/phui-workboard-view.css
@@ -37,54 +37,6 @@
background: {$lightbluetext};
}
-.phui-workboard-action-list {
- width: 60px;
- float: left;
- min-height: 60px;
- border-radius: 5px;
- margin-right: 8px;
- background: {$lightbluebackground};
- border: 1px solid {$lightblueborder};
- border-bottom: 1px solid {$blueborder};
-}
-
-.device-phone .phui-workboard-action-list {
- width: 100%;
- float: none;
- display: block;
- overflow: hidden;
- border: none;
- background: none;
- border-radius: none;
- min-height: 0;
-}
-
-.phui-workboard-action-list li:first-child {
- padding-top: 5px;
-}
-
-.device-phone .phui-workboard-action-list li {
- display: inline;
- float: left;
- margin: 0;
- padding: 0 0 8px 0;
-}
-
-.phui-workboard-action-list .phui-icon-view {
- display: inline-block;
- vertical-align: top;
- width: 50px;
- height: 50px;
- margin: 0 4px 5px 5px;
-}
-
-.device-phone .phui-workboard-action-list .phui-icon-view {
- background-size: 35px;
- height: 35px;
- width: 35px;
- margin: 0 3px;
-}
-
.device-desktop .project-board-wrapper .phui-workboard-view-shadow {
left: 53px;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 9:27 PM (6 d, 19 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7703901
Default Alt Text
D14864.diff (4 KB)
Attached To
Mode
D14864: Remove various unused beahviors from PHUIWorkboardView
Attached
Detach File
Event Timeline
Log In to Comment