Page MenuHomePhabricator
Files F15384745

D10370.id24960.diff
No OneTemporary
Actions

D10370.id24960.diff
View Options

diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php
new file mode 100644
--- /dev/null
+++ b/src/lint/linter/ArcanistPhpLinter.php
@@ -0,0 +1,81 @@
+<?php
+
+/**
+ * Uses "php -l" to detect syntax errors in PHP code.
+ */
+final class ArcanistPhpLinter extends ArcanistExternalLinter {
+
+ public function getInfoName() {
+ return 'php -l';
+ }
+
+ public function getInfoURI() {
+ return 'http://php.net/';
+ }
+
+ public function getInfoDescription() {
+ return pht(
+ 'Checks for syntax errors in php files');
+ }
+
+ public function getLinterName() {
+ return 'PHP';
+ }
+
+ public function getLinterConfigurationName() {
+ return 'php';
+ }
+
+ public function getMandatoryFlags() {
+ return array('-l');
+ }
+
+ public function getInstallInstructions() {
+ return pht('Install PHP');
+ }
+
+ public function getDefaultBinary() {
+ return $this->getDeprecatedConfiguration('lint.php.bin', 'php');
+ }
+
+ public function getVersion() {
+ list($stdout) = execx('%C --version', $this->getExecutableCommand());
+
+ $matches = array();
+ $regex = '/^PHP (?P<version>\d+\.\d+\.\d+)\b/';
+ if (preg_match($regex, $stdout, $matches)) {
+ return $matches['version'];
+ } else {
+ return false;
+ }
+ }
+
+ public function shouldExpectCommandErrors() {
+ return true;
+ }
+
+ public function supportsReadDataFromStdin() {
+ return false;
+ }
+
+ protected function parseLinterOutput($path, $err, $stdout, $stderr) {
+ $matches = array();
+ if (preg_match('/syntax error, (.*?) in (.*?) on line (\d*)/',
+ $stdout, $matches)) {
+
+ $message = new ArcanistLintMessage();
+ $message->setPath($matches[2]);
+ $message->setLine($matches[3]);
+ $message->setCode('php.syntax');
+ $message->setDescription('This file contains a syntax error: '.
+ $matches[1].' on line '.$matches[3]);
+ $message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);
+
+ // php -l only returns the first syntax error
+ return array($message);
+ }
+
+ return array();
+ }
+
+}

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 8:42 PM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7703484
Default Alt Text
D10370.id24960.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility