Page MenuHomePhabricator
Files F15384339

D9496.id22752.diff
No OneTemporary
Actions

D9496.id22752.diff
View Options

diff --git a/src/applications/harbormaster/event/HarbormasterUIEventListener.php b/src/applications/harbormaster/event/HarbormasterUIEventListener.php
--- a/src/applications/harbormaster/event/HarbormasterUIEventListener.php
+++ b/src/applications/harbormaster/event/HarbormasterUIEventListener.php
@@ -74,41 +74,8 @@
$status = $build->getBuildStatus();
$status_name = HarbormasterBuild::getBuildStatusName($status);
-
- switch ($status) {
- case HarbormasterBuild::STATUS_INACTIVE:
- $icon = PHUIStatusItemView::ICON_OPEN;
- $color = 'dark';
- break;
- case HarbormasterBuild::STATUS_PENDING:
- $icon = PHUIStatusItemView::ICON_OPEN;
- $color = 'blue';
- break;
- case HarbormasterBuild::STATUS_BUILDING:
- $icon = PHUIStatusItemView::ICON_RIGHT;
- $color = 'blue';
- break;
- case HarbormasterBuild::STATUS_PASSED:
- $icon = PHUIStatusItemView::ICON_ACCEPT;
- $color = 'green';
- break;
- case HarbormasterBuild::STATUS_FAILED:
- $icon = PHUIStatusItemView::ICON_REJECT;
- $color = 'red';
- break;
- case HarbormasterBuild::STATUS_ERROR:
- $icon = PHUIStatusItemView::ICON_MINUS;
- $color = 'red';
- break;
- case HarbormasterBuild::STATUS_STOPPED:
- $icon = PHUIStatusItemView::ICON_MINUS;
- $color = 'dark';
- break;
- default:
- $icon = PHUIStatusItemView::ICON_QUESTION;
- $color = 'bluegrey';
- break;
- }
+ $icon = HarbormasterBuild::getBuildStatusIcon($status);
+ $color = HarbormasterBuild::getBuildStatusColor($status);
$item->setIcon($icon, $color, $status_name);
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php
--- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php
@@ -75,6 +75,45 @@
}
}
+ public static function getBuildStatusIcon($status) {
+ switch ($status) {
+ case self::STATUS_INACTIVE:
+ case self::STATUS_PENDING:
+ return PHUIStatusItemView::ICON_OPEN;
+ case self::STATUS_BUILDING:
+ return PHUIStatusItemView::ICON_RIGHT;
+ case self::STATUS_PASSED:
+ return PHUIStatusItemView::ICON_ACCEPT;
+ case self::STATUS_FAILED:
+ return PHUIStatusItemView::ICON_REJECT;
+ case self::STATUS_ERROR:
+ return PHUIStatusItemView::ICON_MINUS;
+ case self::STATUS_STOPPED:
+ return PHUIStatusItemView::ICON_MINUS;
+ default:
+ return PHUIStatusItemView::ICON_QUESTION;
+ }
+ }
+
+ public static function getBuildStatusColor($status) {
+ switch ($status) {
+ case self::STATUS_INACTIVE:
+ return 'dark';
+ case self::STATUS_PENDING:
+ case self::STATUS_BUILDING:
+ return 'blue';
+ case self::STATUS_PASSED:
+ return 'green';
+ case self::STATUS_FAILED:
+ case self::STATUS_ERROR:
+ return 'red';
+ case self::STATUS_STOPPED:
+ return 'dark';
+ default:
+ return 'bluegrey';
+ }
+ }
+
public static function initializeNewBuild(PhabricatorUser $actor) {
return id(new HarbormasterBuild())
->setBuildStatus(self::STATUS_INACTIVE);

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 7:34 PM (1 w, 13 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7702473
Default Alt Text
D9496.id22752.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility